RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices

Browse Source 
This patch fixes a compiler crash that was hit when trying to simplify
the following code:

getelementptr [2 x i64], [2 x i64]* null, i64 0, <vscale x 2 x i64> zeroinitializer

For the case where we have a null pointer value like above, we just
need to ensure we don't assume the indices are always fixed width.

Differential Revision: https://reviews.llvm.org/D82183
This commit is contained in:
David Sherwood 2020-06-19 14:33:20 +01:00
parent dde06ce03d
commit 92662d71cb
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/IR/ConstantFold.cpp
View File

@ -2298,18 +2298,17 @@ Constant *llvm::ConstantFoldGetElementPtr(Type *PointeeTy, Constant *C,
assert(Ty && "Invalid indices for GEP!");
Type *OrigGEPTy = PointerType::get(Ty, PtrTy->getAddressSpace());
Type *GEPTy = PointerType::get(Ty, PtrTy->getAddressSpace());
if (VectorType *VT = dyn_cast<VectorType>(C->getType())) {
// FIXME: handle scalable vectors (use getElementCount())
GEPTy = FixedVectorType::get(
OrigGEPTy, cast<FixedVectorType>(VT)->getNumElements());
}
if (VectorType *VT = dyn_cast<VectorType>(C->getType()))
GEPTy = VectorType::get(OrigGEPTy, VT->getElementCount());
// The GEP returns a vector of pointers when one of more of
// its arguments is a vector.
for (unsigned i = 0, e = Idxs.size(); i != e; ++i) {
if (auto *VT = dyn_cast<VectorType>(Idxs[i]->getType())) {
// FIXME: handle scalable vectors
GEPTy = FixedVectorType::get(
OrigGEPTy, cast<FixedVectorType>(VT)->getNumElements());
assert((!isa<VectorType>(GEPTy) || isa<ScalableVectorType>(GEPTy) ==
isa<ScalableVectorType>(VT)) &&
"Mismatched GEPTy vector types");
GEPTy = VectorType::get(OrigGEPTy, VT->getElementCount());
break;
}
}

8
test/Transforms/InstSimplify/gep.ll
View File

@ -176,4 +176,12 @@ define <vscale x 4 x float*> @scalable_vector_idx_mix_scalar_vector() {
ret <vscale x 4 x float*> %gep
}
define <vscale x 2 x i64*> @ptr_idx_mix_scalar_scalable_vector() {
; CHECK-LABEL: @ptr_idx_mix_scalar_scalable_vector(
; CHECK-NEXT: ret <vscale x 2 x i64*> zeroinitializer
;
%v = getelementptr [2 x i64], [2 x i64]* null, i64 0, <vscale x 2 x i64> zeroinitializer
ret <vscale x 2 x i64*> %v
}
; Check ConstantExpr::getGetElementPtr() using ElementCount for size queries - end.