RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 18:54:02 +01:00
Code Issues Projects Releases Wiki Activity

[AArch64][GlobalISel] Fall back when translating musttail calls

Browse Source 
These are currently translated as normal functions calls in AArch64.

Until we have proper tail call lowering, we shouldn't translate these.

Differential Revision: https://reviews.llvm.org/D66842

llvm-svn: 370225
This commit is contained in:
Jessica Paquette 2019-08-28 16:19:01 +00:00
parent ca21fc4ae3
commit 981e1678af
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/llvm/CodeGen/GlobalISel/CallLowering.h
View File

@ -80,6 +80,9 @@ public:
Register SwiftErrorVReg = 0;
MDNode *KnownCallees = nullptr;
/// True if the call must be tail call optimized.
bool IsMustTailCall = false;
};
/// Argument handling is mostly uniform between the four places that

1
lib/CodeGen/GlobalISel/CallLowering.cpp
View File

@ -62,6 +62,7 @@ bool CallLowering::lowerCall(MachineIRBuilder &MIRBuilder, ImmutableCallSite CS,
CS.getInstruction()->getMetadata(LLVMContext::MD_callees);
Info.CallConv = CS.getCallingConv();
Info.SwiftErrorVReg = SwiftErrorVReg;
Info.IsMustTailCall = CS.isMustTailCall();
return lowerCall(MIRBuilder, Info);
}

5
lib/Target/AArch64/AArch64CallLowering.cpp
View File

@ -409,6 +409,11 @@ bool AArch64CallLowering::lowerCall(MachineIRBuilder &MIRBuilder,
MachineRegisterInfo &MRI = MF.getRegInfo();
auto &DL = F.getParent()->getDataLayout();
if (Info.IsMustTailCall) {
LLVM_DEBUG(dbgs() << "Cannot lower musttail calls yet.\n");
return false;
}
SmallVector<ArgInfo, 8> SplitArgs;
for (auto &OrigArg : Info.OrigArgs) {
splitToValueTypes(OrigArg, SplitArgs, DL, MRI, Info.CallConv);

9
test/CodeGen/AArch64/GlobalISel/call-translator-musttail.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: not llc %s -mtriple aarch64-unknown-unknown -debug-only=aarch64-call-lowering -global-isel -o - 2>&1 | FileCheck %s
; CHECK: Cannot lower musttail calls yet.
; CHECK-NEXT: LLVM ERROR: unable to translate instruction: call (in function: foo)
declare void @must_callee(i8*)
define void @foo(i32*) {
musttail call void @must_callee(i8* null)
ret void
}