From 9928505155d5684db29de7c6ec28cb5fd9abc139 Mon Sep 17 00:00:00 2001 From: Hubert Tong Date: Sat, 9 Feb 2019 02:11:51 +0000 Subject: [PATCH] [MC] Clean up unused inline function and non-anchor defaulted destructors; NFCI Summary: Take care of some missing clean-ups that belong with r249548 and some other copy/paste that had happened. In particular, the destructors are no longer vtable anchors after r249548; and `setSectionName` in `MCSectionWasm` is private and unused since r313058 culled its only caller. The destructors are now implicitly defined, and the unused function is removed. Reviewers: nemanjai, jasonliu, grosbach Reviewed By: nemanjai Subscribers: sbc100, aheejin, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D57182 llvm-svn: 353597 --- include/llvm/MC/MCSectionCOFF.h | 2 -- include/llvm/MC/MCSectionELF.h | 2 -- include/llvm/MC/MCSectionWasm.h | 4 ---- lib/MC/MCSectionCOFF.cpp | 2 -- lib/MC/MCSectionELF.cpp | 2 -- lib/MC/MCSectionWasm.cpp | 2 -- 6 files changed, 14 deletions(-) diff --git a/include/llvm/MC/MCSectionCOFF.h b/include/llvm/MC/MCSectionCOFF.h index 68618f1960c..8be95e0f1de 100644 --- a/include/llvm/MC/MCSectionCOFF.h +++ b/include/llvm/MC/MCSectionCOFF.h @@ -62,8 +62,6 @@ private: } public: - ~MCSectionCOFF(); - /// Decides whether a '.section' directive should be printed before the /// section name bool ShouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const; diff --git a/include/llvm/MC/MCSectionELF.h b/include/llvm/MC/MCSectionELF.h index f61cd03bd42..fe6b2d7afc7 100644 --- a/include/llvm/MC/MCSectionELF.h +++ b/include/llvm/MC/MCSectionELF.h @@ -63,8 +63,6 @@ private: void setSectionName(StringRef Name) { SectionName = Name; } public: - ~MCSectionELF(); - /// Decides whether a '.section' directive should be printed before the /// section name bool ShouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const; diff --git a/include/llvm/MC/MCSectionWasm.h b/include/llvm/MC/MCSectionWasm.h index 15f618a5235..0e576b7ba40 100644 --- a/include/llvm/MC/MCSectionWasm.h +++ b/include/llvm/MC/MCSectionWasm.h @@ -48,11 +48,7 @@ class MCSectionWasm final : public MCSection { : MCSection(SV_Wasm, K, Begin), SectionName(Section), UniqueID(UniqueID), Group(group) {} - void setSectionName(StringRef Name) { SectionName = Name; } - public: - ~MCSectionWasm(); - /// Decides whether a '.section' directive should be printed before the /// section name bool shouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const; diff --git a/lib/MC/MCSectionCOFF.cpp b/lib/MC/MCSectionCOFF.cpp index 8fd4c64d0d9..f0c06f70bd7 100644 --- a/lib/MC/MCSectionCOFF.cpp +++ b/lib/MC/MCSectionCOFF.cpp @@ -14,8 +14,6 @@ using namespace llvm; -MCSectionCOFF::~MCSectionCOFF() = default; // anchor. - // ShouldOmitSectionDirective - Decides whether a '.section' directive // should be printed before the section name bool MCSectionCOFF::ShouldOmitSectionDirective(StringRef Name, diff --git a/lib/MC/MCSectionELF.cpp b/lib/MC/MCSectionELF.cpp index dd883665e0b..e3c24efa93f 100644 --- a/lib/MC/MCSectionELF.cpp +++ b/lib/MC/MCSectionELF.cpp @@ -17,8 +17,6 @@ using namespace llvm; -MCSectionELF::~MCSectionELF() = default; // anchor. - // Decides whether a '.section' directive // should be printed before the section name. bool MCSectionELF::ShouldOmitSectionDirective(StringRef Name, diff --git a/lib/MC/MCSectionWasm.cpp b/lib/MC/MCSectionWasm.cpp index a8f56897ee1..164ded9a1f8 100644 --- a/lib/MC/MCSectionWasm.cpp +++ b/lib/MC/MCSectionWasm.cpp @@ -14,8 +14,6 @@ using namespace llvm; -MCSectionWasm::~MCSectionWasm() = default; // anchor. - // Decides whether a '.section' directive // should be printed before the section name. bool MCSectionWasm::shouldOmitSectionDirective(StringRef Name,