RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 02:52:53 +02:00
Code Issues Projects Releases Wiki Activity

llvm-cov: Don't pointlessly create a unique_ptr (NFC)

Browse Source 
There's no ownership going on here, and no reason to heap allocate
this object.

llvm-svn: 217113
This commit is contained in:
Justin Bogner 2014-09-04 00:04:54 +00:00
parent d318de5814
commit a1e018be46
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tools/llvm-cov/CodeCoverage.cpp
View File

@ -615,18 +615,17 @@ int CodeCoverageTool::show(int argc, const char **argv,
if (findMainViewFileID(Function, MainFileID))
continue;
StringRef SourceFile = Function.Filenames[MainFileID];
std::unique_ptr<SourceCoverageView> mainView;
auto SourceBuffer = getSourceFile(SourceFile);
if (!SourceBuffer)
return 1;
auto Range = findExpandedFileInterestingLineRange(MainFileID, Function);
mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts,
Range.first, Range.second));
createSourceFileView(SourceFile, *mainView, Function, true);
SourceCoverageView mainView(SourceBuffer.get(), ViewOpts, Range.first,
Range.second);
createSourceFileView(SourceFile, mainView, Function, true);
ViewOpts.colored_ostream(outs(), raw_ostream::CYAN)
<< Function.PrettyName << " from " << SourceFile << ":";
outs() << "\n";
mainView->render(outs());
mainView.render(outs());
if (FunctionMappingRecords.size() > 1)
outs() << "\n";
}
@ -648,12 +647,11 @@ int CodeCoverageTool::show(int argc, const char **argv,
}
for (const auto &SourceFile : SourceFiles) {
std::unique_ptr<SourceCoverageView> mainView;
auto SourceBuffer = getSourceFile(SourceFile);
if (!SourceBuffer)
return 1;
mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts));
if (createSourceFileView(SourceFile, *mainView, FunctionMappingRecords)) {
SourceCoverageView mainView(SourceBuffer.get(), ViewOpts);
if (createSourceFileView(SourceFile, mainView, FunctionMappingRecords)) {
ViewOpts.colored_ostream(outs(), raw_ostream::RED)
<< "warning: The file '" << SourceFile << "' isn't covered.";
outs() << "\n";
@ -664,7 +662,7 @@ int CodeCoverageTool::show(int argc, const char **argv,
ViewOpts.colored_ostream(outs(), raw_ostream::CYAN) << SourceFile << ":";
outs() << "\n";
}
mainView->render(outs());
mainView.render(outs());
if (SourceFiles.size() > 1)
outs() << "\n";
}