RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00
Code Issues Projects Releases Wiki Activity

[InstCombine] Disable recursion in foldGEPICmp for vector pointer GEPs

Browse Source 
Due to missing vector support in this function, recursion can
generate worse code in some cases.

llvm-svn: 370221
This commit is contained in:
Craig Topper 2019-08-28 15:40:34 +00:00
parent 7239307170
commit a8988785a1
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Transforms/InstCombine/InstCombineCompares.cpp
View File

@ -988,12 +988,14 @@ Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
} }
// If one of the GEPs has all zero indices, recurse. // If one of the GEPs has all zero indices, recurse.
if (GEPLHS->hasAllZeroIndices()) // FIXME: Handle vector of pointers.
if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices())
return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
ICmpInst::getSwappedPredicate(Cond), I); ICmpInst::getSwappedPredicate(Cond), I);
// If the other GEP has all zero indices, recurse. // If the other GEP has all zero indices, recurse.
if (GEPRHS->hasAllZeroIndices()) // FIXME: Handle vector of pointers.
if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices())
return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();

12
test/Transforms/InstCombine/gep-custom-dl.ll
View File

@ -110,6 +110,18 @@ define <2 x i1> @test6(<2 x i32> %X, <2 x %S*> %P) nounwind {
ret <2 x i1> %C ret <2 x i1> %C
} }
; Same as above, but indices scalarized.
define <2 x i1> @test6b(<2 x i32> %X, <2 x %S*> %P) nounwind {
; CHECK-LABEL: @test6b(
; CHECK-NEXT: [[C:%.*]] = icmp eq <2 x i32> [[X:%.*]], <i32 1073741823, i32 1073741823>
; CHECK-NEXT: ret <2 x i1> [[C]]
;
%A = getelementptr inbounds %S, <2 x %S*> %P, i32 0, i32 1, <2 x i32> %X
%B = getelementptr inbounds %S, <2 x %S*> %P, i32 0, i32 0
%C = icmp eq <2 x i32*> %A, %B
ret <2 x i1> %C
}
@G = external global [3 x i8] @G = external global [3 x i8]
define i8* @test7(i16 %Idx) { define i8* @test7(i16 %Idx) {
; CHECK-LABEL: @test7( ; CHECK-LABEL: @test7(