diff --git a/lib/Transforms/Utils/Local.cpp b/lib/Transforms/Utils/Local.cpp index 4d76aae2971..edacfd20f99 100644 --- a/lib/Transforms/Utils/Local.cpp +++ b/lib/Transforms/Utils/Local.cpp @@ -1414,6 +1414,12 @@ static bool markAliveBlocks(Function &F, } if (CallInst *CI = dyn_cast(BBI)) { + Value *Callee = CI->getCalledValue(); + if (isa(Callee) || isa(Callee)) { + changeToUnreachable(CI, /*UseLLVMTrap=*/false); + Changed = true; + break; + } if (CI->doesNotReturn()) { // If we found a call to a no-return function, insert an unreachable // instruction after it. Make sure there isn't *already* one there diff --git a/lib/Transforms/Utils/SimplifyCFG.cpp b/lib/Transforms/Utils/SimplifyCFG.cpp index d22f5c63dee..7924c33038a 100644 --- a/lib/Transforms/Utils/SimplifyCFG.cpp +++ b/lib/Transforms/Utils/SimplifyCFG.cpp @@ -5388,7 +5388,7 @@ static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I) { if (I->use_empty()) return false; - if (C->isNullValue()) { + if (C->isNullValue() || isa(C)) { // Only look at the first use, avoid hurting compile time with long uselists User *Use = *I->user_begin(); @@ -5417,6 +5417,10 @@ static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I) { if (!SI->isVolatile()) return SI->getPointerAddressSpace() == 0 && SI->getPointerOperand() == I; + + // A call to null is undefined. + if (auto CS = CallSite(Use)) + return CS.getCalledValue() == I; } return false; } diff --git a/test/Transforms/SimplifyCFG/UnreachableEliminate.ll b/test/Transforms/SimplifyCFG/UnreachableEliminate.ll index 87872a6a8a1..be612b288b7 100644 --- a/test/Transforms/SimplifyCFG/UnreachableEliminate.ll +++ b/test/Transforms/SimplifyCFG/UnreachableEliminate.ll @@ -96,3 +96,34 @@ bb2: store i8 2, i8* %ptr.2, align 8 ret void } + +define i32 @test7(i1 %X) { +entry: + br i1 %X, label %if, label %else + +if: + call void undef() + br label %else + +else: + %phi = phi i32 [ 0, %entry ], [ 1, %if ] + ret i32 %phi +} +; CHECK-LABEL: define i32 @test7( +; CHECK-NOT: call +; CHECK: ret i32 0 + +define void @test8(i1 %X, void ()* %Y) { +entry: + br i1 %X, label %if, label %else + +if: + br label %else + +else: + %phi = phi void ()* [ %Y, %entry ], [ null, %if ] + call void %phi() + ret void +} +; CHECK-LABEL: define void @test8( +; CHECK: call void %Y(