RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

[InstCombine] matchFunnelShift - canonicalize to OR(SHL,LSHR). NFCI.

Browse Source 
Simplify the shift amount matching code by canonicalizing the shift ops first.
This commit is contained in:
Simon Pilgrim 2020-10-12 15:10:16 +01:00
parent 79d37fda95
commit ab2599111f
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
View File

@ -2067,13 +2067,19 @@ static Instruction *matchFunnelShift(Instruction &Or) {
Value *ShVal0, *ShVal1, *ShAmt0, *ShAmt1; Value *ShVal0, *ShVal1, *ShAmt0, *ShAmt1;
if (!match(Or0, m_OneUse(m_LogicalShift(m_Value(ShVal0), m_Value(ShAmt0)))) || if (!match(Or0, m_OneUse(m_LogicalShift(m_Value(ShVal0), m_Value(ShAmt0)))) ||
!match(Or1, m_OneUse(m_LogicalShift(m_Value(ShVal1), m_Value(ShAmt1))))) !match(Or1, m_OneUse(m_LogicalShift(m_Value(ShVal1), m_Value(ShAmt1)))) ||
Or0->getOpcode() == Or1->getOpcode())
return nullptr; return nullptr;
BinaryOperator::BinaryOps ShiftOpcode0 = Or0->getOpcode(); // Canonicalize to or(shl(ShVal0, ShAmt0), lshr(ShVal1, ShAmt1)).
BinaryOperator::BinaryOps ShiftOpcode1 = Or1->getOpcode(); if (Or0->getOpcode() == BinaryOperator::LShr) {
if (ShiftOpcode0 == ShiftOpcode1) std::swap(Or0, Or1);
return nullptr; std::swap(ShVal0, ShVal1);
std::swap(ShAmt0, ShAmt1);
}
assert(Or0->getOpcode() == BinaryOperator::Shl &&
Or1->getOpcode() == BinaryOperator::LShr &&
"Illegal or(shift,shift) pair");
// Match the shift amount operands for a funnel shift pattern. This always // Match the shift amount operands for a funnel shift pattern. This always
// matches a subtraction on the R operand. // matches a subtraction on the R operand.
@ -2124,16 +2130,14 @@ static Instruction *matchFunnelShift(Instruction &Or) {
}; };
Value *ShAmt = matchShiftAmount(ShAmt0, ShAmt1, Width); Value *ShAmt = matchShiftAmount(ShAmt0, ShAmt1, Width);
bool SubIsOnLHS = false; bool IsFshl = true; // Sub on LSHR.
if (!ShAmt) { if (!ShAmt) {
ShAmt = matchShiftAmount(ShAmt1, ShAmt0, Width); ShAmt = matchShiftAmount(ShAmt1, ShAmt0, Width);
SubIsOnLHS = true; IsFshl = false; // Sub on SHL.
} }
if (!ShAmt) if (!ShAmt)
return nullptr; return nullptr;
bool IsFshl = (!SubIsOnLHS && ShiftOpcode0 == BinaryOperator::Shl) ||
(SubIsOnLHS && ShiftOpcode1 == BinaryOperator::Shl);
Intrinsic::ID IID = IsFshl ? Intrinsic::fshl : Intrinsic::fshr; Intrinsic::ID IID = IsFshl ? Intrinsic::fshl : Intrinsic::fshr;
Function *F = Intrinsic::getDeclaration(Or.getModule(), IID, Or.getType()); Function *F = Intrinsic::getDeclaration(Or.getModule(), IID, Or.getType());
return IntrinsicInst::Create( return IntrinsicInst::Create(