RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 11:13:28 +01:00
Code Issues Projects Releases Wiki Activity

[DebugInfo/Verifier] Don't emit error for missing module in index

Browse Source 
We don't expect module names to be present in the index. This patch adds
DW_TAG_module to the blacklist.

Differential revision: https://reviews.llvm.org/D50237

llvm-svn: 338878
This commit is contained in:
Jonas Devlieghere 2018-08-03 12:01:43 +00:00
parent e8819358a0
commit ad1fff0c4d
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/DebugInfo/DWARF/DWARFVerifier.cpp
View File

@ -1211,8 +1211,9 @@ unsigned DWARFVerifier::verifyNameIndexCompleteness(
// make sure we catch any missing items, we instead blacklist all TAGs that we // make sure we catch any missing items, we instead blacklist all TAGs that we
// know shouldn't be indexed. // know shouldn't be indexed.
switch (Die.getTag()) { switch (Die.getTag()) {
// Compile unit has a name but it shouldn't be indexed. // Compile units and modules have names but shouldn't be indexed.
case DW_TAG_compile_unit: case DW_TAG_compile_unit:
case DW_TAG_module:
return 0; return 0;
// Function and template parameters are not globally visible, so we shouldn't // Function and template parameters are not globally visible, so we shouldn't

3
test/DebugInfo/X86/DIModule.ll
View File

@ -1,6 +1,7 @@
; ModuleID = '/Volumes/Data/apple-internal/llvm/tools/clang/test/Modules/debug-info-moduleimport.m' ; ModuleID = '/Volumes/Data/apple-internal/llvm/tools/clang/test/Modules/debug-info-moduleimport.m'
; RUN: llc %s -o %t -filetype=obj ; RUN: llc %s -accel-tables=Dwarf -o %t -filetype=obj
; RUN: llvm-dwarfdump -debug-info %t | FileCheck %s ; RUN: llvm-dwarfdump -debug-info %t | FileCheck %s
; RUN: llvm-dwarfdump -verify %t
; CHECK: DW_TAG_module ; CHECK: DW_TAG_module
; CHECK-NEXT: DW_AT_name {{.*}}"DebugModule" ; CHECK-NEXT: DW_AT_name {{.*}}"DebugModule"
; CHECK-NEXT: DW_AT_LLVM_config_macros {{.*}}"-DMODULES=0" ; CHECK-NEXT: DW_AT_LLVM_config_macros {{.*}}"-DMODULES=0"