From b0b0a7801dae4505d0a53e716742e267360777af Mon Sep 17 00:00:00 2001 From: Christopher Tetreault Date: Tue, 30 Jun 2020 10:56:36 -0700 Subject: [PATCH] [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine Reviewers: efriedma, lhames, sdesmalen, fpetrogalli Reviewed By: lhames, sdesmalen Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D82211 --- lib/ExecutionEngine/ExecutionEngine.cpp | 28 ++++++++++++++++--------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/lib/ExecutionEngine/ExecutionEngine.cpp b/lib/ExecutionEngine/ExecutionEngine.cpp index 6b384f1d0eb..d8bd671c666 100644 --- a/lib/ExecutionEngine/ExecutionEngine.cpp +++ b/lib/ExecutionEngine/ExecutionEngine.cpp @@ -9,6 +9,8 @@ // This file defines the common interface used by the various execution engine // subclasses. // +// FIXME: This file needs to be updated to support scalable vectors +// //===----------------------------------------------------------------------===// #include "llvm/ExecutionEngine/ExecutionEngine.h" @@ -624,10 +626,12 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) { } } break; - case Type::FixedVectorTyID: case Type::ScalableVectorTyID: + report_fatal_error( + "Scalable vector support not yet implemented in ExecutionEngine"); + case Type::FixedVectorTyID: // if the whole vector is 'undef' just reserve memory for the value. - auto *VTy = cast(C->getType()); + auto *VTy = cast(C->getType()); Type *ElemTy = VTy->getElementType(); unsigned int elemNum = VTy->getNumElements(); Result.AggregateVal.resize(elemNum); @@ -915,8 +919,10 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) { else llvm_unreachable("Unknown constant pointer type!"); break; - case Type::FixedVectorTyID: - case Type::ScalableVectorTyID: { + case Type::ScalableVectorTyID: + report_fatal_error( + "Scalable vector support not yet implemented in ExecutionEngine"); + case Type::FixedVectorTyID: { unsigned elemNum; Type* ElemTy; const ConstantDataVector *CDV = dyn_cast(C); @@ -927,9 +933,9 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) { elemNum = CDV->getNumElements(); ElemTy = CDV->getElementType(); } else if (CV || CAZ) { - auto* VTy = cast(C->getType()); - elemNum = VTy->getNumElements(); - ElemTy = VTy->getElementType(); + auto *VTy = cast(C->getType()); + elemNum = VTy->getNumElements(); + ElemTy = VTy->getElementType(); } else { llvm_unreachable("Unknown constant vector type!"); } @@ -1098,9 +1104,11 @@ void ExecutionEngine::LoadValueFromMemory(GenericValue &Result, Result.IntVal = APInt(80, y); break; } - case Type::FixedVectorTyID: - case Type::ScalableVectorTyID: { - auto *VT = cast(Ty); + case Type::ScalableVectorTyID: + report_fatal_error( + "Scalable vector support not yet implemented in ExecutionEngine"); + case Type::FixedVectorTyID: { + auto *VT = cast(Ty); Type *ElemT = VT->getElementType(); const unsigned numElems = VT->getNumElements(); if (ElemT->isFloatTy()) {