Revert "[llvm-cov] Add an -output-dir option for the show sub-command"

This reverts commit r273971. test/profile/instrprof-visibility.cpp is
failing because of an uncaught error in SafelyCloseFileDescriptor.

llvm-svn: 273978

docs/CommandGuide/llvm-cov.rst

@@ -240,14 +240,6 @@ OPTIONS
 
  Use the specified output format. The supported formats are: "text".
 
-.. option:: -output-dir=PATH
-
- Specify a directory to write coverage reports into. If the directory does not
- exist, it is created. When used in function view mode (i.e when -name or
- -name-regex are used to select specific functions), the report is written to
- PATH/functions.EXTENSION. When used in file view mode, a report for each file
- is written to PATH/REL_PATH_TO_FILE.EXTENSION.
-
 .. option:: -line-coverage-gt=<N>
 
  Show code coverage only for functions with line coverage greater than the

test/tools/llvm-cov/showLineExecutionCounts.cpp

@@ -28,9 +28,3 @@ int main() {                             // CHECK:   161| [[@LINE]]|int main(
 
 // RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -instr-profile %t.profdata -filename-equivalence %s | FileCheck -check-prefixes=CHECK,WHOLE-FILE %s
 // RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -instr-profile %t.profdata -filename-equivalence -name=main %s | FileCheck -check-prefixes=CHECK,FILTER %s
-
-// Test -output-dir.
-// RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -output-dir %t.dir -instr-profile %t.profdata -filename-equivalence %s
-// RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -output-dir %t.dir -instr-profile %t.profdata -filename-equivalence -name=main %s
-// RUN: FileCheck -check-prefixes=CHECK,WHOLE-FILE -input-file %t.dir/coverage/tmp/showLineExecutionCounts.cpp.txt %s
-// RUN: FileCheck -check-prefixes=CHECK,FILTER -input-file %t.dir/functions.txt %s

tools/llvm-cov/CodeCoverage.cpp

@@ -406,12 +406,6 @@ int CodeCoverageTool::show(int argc, const char **argv,
                  clEnumValEnd),
       cl::init(CoverageViewOptions::OutputFormat::Text));
 
-  cl::opt<std::string> ShowOutputDirectory(
-      "output-dir", cl::init(""),
-      cl::desc("Directory in which coverage information is written out"));
-  cl::alias ShowOutputDirectoryA("o", cl::desc("Alias for --output-dir"),
-                                 cl::aliasopt(ShowOutputDirectory));
-
   auto Err = commandLineParser(argc, argv);
   if (Err)
     return Err;
@@ -424,14 +418,6 @@ int CodeCoverageTool::show(int argc, const char **argv,
   ViewOpts.ShowExpandedRegions = ShowExpansions;
   ViewOpts.ShowFunctionInstantiations = ShowInstantiations;
   ViewOpts.ShowFormat = ShowFormat;
-  ViewOpts.ShowOutputDirectory = ShowOutputDirectory;
-
-  if (ViewOpts.ShowOutputDirectory != "") {
-    if (auto E = sys::fs::create_directories(ViewOpts.ShowOutputDirectory)) {
-      error("Could not create output directory!", E.message());
-      return 1;
-    }
-  }
 
   auto Coverage = load();
   if (!Coverage)
@@ -450,17 +436,8 @@ int CodeCoverageTool::show(int argc, const char **argv,
             << "\n";
         continue;
       }
-
-      auto OSOrErr =
-          mainView->createOutputFile("functions", /*InToplevel=*/true);
-      if (Error E = OSOrErr.takeError()) {
-        handleAllErrors(OSOrErr.takeError(),
-                        [&](const ErrorInfoBase &EI) { error(EI.message()); });
-        return 1;
-      }
-      std::unique_ptr<raw_ostream> OS = std::move(OSOrErr.get());
-      mainView->print(*OS.get(), /*WholeFile=*/false, /*ShowSourceName=*/true);
-      mainView->closeOutputFile(std::move(OS));
+      mainView->print(outs(), /*WholeFile=*/false, /*ShowSourceName=*/true);
+      outs() << "\n";
     }
     return 0;
   }
@@ -482,16 +459,10 @@ int CodeCoverageTool::show(int argc, const char **argv,
       continue;
     }
 
-    auto OSOrErr = mainView->createOutputFile(SourceFile, /*InToplevel=*/false);
-    if (Error E = OSOrErr.takeError()) {
-      handleAllErrors(OSOrErr.takeError(),
-                      [&](const ErrorInfoBase &EI) { error(EI.message()); });
-      return 1;
-    }
-    std::unique_ptr<raw_ostream> OS = std::move(OSOrErr.get());
-    mainView->print(*OS.get(), /*Wholefile=*/true,
+    mainView->print(outs(), /*Wholefile=*/true,
                     /*ShowSourceName=*/ShowFilenames);
-    mainView->closeOutputFile(std::move(OS));
+    if (SourceFiles.size() > 1)
+      outs() << "\n";
   }
 
   return 0;

tools/llvm-cov/CoverageViewOptions.h

@@ -30,7 +30,6 @@ struct CoverageViewOptions {
   bool ShowFunctionInstantiations;
   bool ShowFullFilenames;
   OutputFormat ShowFormat;
-  std::string ShowOutputDirectory;
 
   /// \brief Change the output's stream color if the colors are enabled.
   ColoredRawOstream colored_ostream(raw_ostream &OS,

tools/llvm-cov/SourceCoverageView.cpp

@@ -15,9 +15,7 @@
 #include "SourceCoverageViewText.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringExtras.h"
-#include "llvm/Support/FileSystem.h"
 #include "llvm/Support/LineIterator.h"
-#include "llvm/Support/Path.h"
 
 using namespace llvm;
 
@@ -36,49 +34,6 @@ std::string SourceCoverageView::formatCount(uint64_t N) {
   return Result;
 }
 
-/// \brief Create a file at ``Dir/ToplevelDir/@Path.Extension``. If
-/// \p ToplevelDir is empty, its path component is skipped.
-static Expected<std::unique_ptr<raw_ostream>>
-createFileInDirectory(StringRef Dir, StringRef ToplevelDir, StringRef Path,
-                      StringRef Extension) {
-  assert(Extension.size() && "The file extension may not be empty");
-
-  SmallString<256> FullPath(Dir);
-  if (!ToplevelDir.empty())
-    sys::path::append(FullPath, ToplevelDir);
-
-  auto PathBaseDir = sys::path::relative_path(sys::path::parent_path(Path));
-  sys::path::append(FullPath, PathBaseDir);
-
-  if (auto E = sys::fs::create_directories(FullPath))
-    return errorCodeToError(E);
-
-  auto PathFilename = (sys::path::filename(Path) + "." + Extension).str();
-  sys::path::append(FullPath, PathFilename);
-
-  std::error_code E;
-  auto OS = llvm::make_unique<raw_fd_ostream>(FullPath, E, sys::fs::F_RW);
-  if (E)
-    return errorCodeToError(E);
-  return std::move(OS);
-}
-
-Expected<std::unique_ptr<raw_ostream>>
-SourceCoverageView::createOutputStream(const CoverageViewOptions &Opts,
-                                       StringRef Path, StringRef Extension,
-                                       bool InToplevel) {
-  if (Opts.ShowOutputDirectory == "") {
-    std::error_code E;
-    auto OS = llvm::make_unique<raw_fd_ostream>("-", E, sys::fs::F_None);
-    if (E)
-      return errorCodeToError(E);
-    return std::move(OS);
-  }
-
-  return createFileInDirectory(Opts.ShowOutputDirectory,
-                               InToplevel ? "" : "coverage", Path, Extension);
-}
-
 void SourceCoverageView::addExpansion(
     const coverage::CounterMappingRegion &Region,
     std::unique_ptr<SourceCoverageView> View) {

tools/llvm-cov/SourceCoverageView.h

@@ -101,7 +101,7 @@ struct LineCoverageStats {
 ///
 /// A source coverage view and its nested sub-views form a file-oriented
 /// representation of code coverage data. This view can be printed out by a
-/// renderer which implements both the File Creation and Rendering interfaces.
+/// renderer which implements the Rendering Interface.
 class SourceCoverageView {
   /// A function or file name.
   StringRef SourceName;
@@ -122,19 +122,6 @@ class SourceCoverageView {
   /// on display.
   std::vector<InstantiationView> InstantiationSubViews;
 
-public:
-  /// @name File Creation Interface
-  /// @{
-
-  /// \brief Create a file to print a coverage view into.
-  virtual Expected<std::unique_ptr<raw_ostream>>
-  createOutputFile(StringRef Path, bool InToplevel) = 0;
-
-  /// \brief Close a file which has been used to print a coverage view.
-  virtual void closeOutputFile(std::unique_ptr<raw_ostream> OS) = 0;
-
-  /// @}
-
 protected:
   struct LineRef {
     StringRef Line;
@@ -196,12 +183,6 @@ protected:
   /// digits.
   static std::string formatCount(uint64_t N);
 
-  /// \brief If directory output is enabled, create a file with \p Path as the
-  /// suffix. Otherwise, return stdout.
-  static Expected<std::unique_ptr<raw_ostream>>
-  createOutputStream(const CoverageViewOptions &Opts, StringRef Path,
-                     StringRef Extension, bool InToplevel);
-
   SourceCoverageView(StringRef SourceName, const MemoryBuffer &File,
                      const CoverageViewOptions &Options,
                      coverage::CoverageData &&CoverageInfo)

tools/llvm-cov/SourceCoverageViewText.cpp

@@ -37,15 +37,6 @@ unsigned getDividerWidth(const CoverageViewOptions &Opts) {
 
 } // anonymous namespace
 
-Expected<std::unique_ptr<raw_ostream>>
-SourceCoverageViewText::createOutputFile(StringRef Path, bool InToplevel) {
-  return createOutputStream(getOptions(), Path, "txt", InToplevel);
-}
-
-void SourceCoverageViewText::closeOutputFile(std::unique_ptr<raw_ostream> OS) {
-  OS.get()->operator<<('\n');
-}
-
 void SourceCoverageViewText::renderSourceName(raw_ostream &OS) {
   getOptions().colored_ostream(OS, raw_ostream::CYAN) << getSourceName()
                                                       << ":\n";

tools/llvm-cov/SourceCoverageViewText.h

@@ -20,13 +20,6 @@ namespace llvm {
 
 /// \brief A code coverage view which supports text-based rendering.
 class SourceCoverageViewText : public SourceCoverageView {
-public:
-  Expected<std::unique_ptr<raw_ostream>>
-  createOutputFile(StringRef Path, bool InToplevel) override;
-
-  void closeOutputFile(std::unique_ptr<raw_ostream> OS) override;
-
-private:
   void renderSourceName(raw_ostream &OS) override;
 
   void renderLinePrefix(raw_ostream &OS, unsigned ViewDepth) override;