RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

AsmParser: Don't crash when insertvalue has bad operands

Browse Source 
llvm-svn: 228813
This commit is contained in:
David Majnemer 2015-02-11 07:43:58 +00:00
parent 9d531d29e7
commit b2167a7a64
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/AsmParser/LLParser.cpp
View File

@ -4951,8 +4951,13 @@ int LLParser::ParseInsertValue(Instruction *&Inst, PerFunctionState &PFS) {
if (!Val0->getType()->isAggregateType())
return Error(Loc0, "insertvalue operand must be aggregate type");
if (!ExtractValueInst::getIndexedType(Val0->getType(), Indices))
Type *IndexedType = ExtractValueInst::getIndexedType(Val0->getType(), Indices);
if (!IndexedType)
return Error(Loc0, "invalid indices for insertvalue");
if (IndexedType != Val1->getType())
return Error(Loc1, "insertvalue operand and field disagree in type: '" +
getTypeString(Val1->getType()) + "' instead of '" +
getTypeString(IndexedType) + "'");
Inst = InsertValueInst::Create(Val0, Val1, Indices);
return AteExtraComma ? InstExtraComma : InstNormal;
}

9
test/Assembler/insertvalue-invalid-type.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: not llvm-as < %s 2>&1 | FileCheck %s
; CHECK: insertvalue operand and field disagree in type: 'i8*' instead of 'i32'
define void @test() {
entry:
insertvalue { i32, i32 } undef, i8* null, 0
ret void
}