From b3b908fad334c7088478b332b5ba68f96214b02d Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Fri, 9 Aug 2013 00:08:46 +0000 Subject: [PATCH] [lit] Eliminate parent argument from TestingConfig.frompath(), which is effectively unused. llvm-svn: 188032 --- utils/lit/lit/LitConfig.py | 2 +- utils/lit/lit/TestingConfig.py | 11 +++++++++-- utils/lit/lit/discovery.py | 5 ++--- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/utils/lit/lit/LitConfig.py b/utils/lit/lit/LitConfig.py index c1836131332..d493b33daa2 100644 --- a/utils/lit/lit/LitConfig.py +++ b/utils/lit/lit/LitConfig.py @@ -73,7 +73,7 @@ class LitConfig: if self.debug: self.note('load_config from %r' % path) return lit.TestingConfig.TestingConfig.frompath( - path, config.parent, self, mustExist = True, config = config) + path, config, self, mustExist = True) def getBashPath(self): """getBashPath - Get the path to 'bash'""" diff --git a/utils/lit/lit/TestingConfig.py b/utils/lit/lit/TestingConfig.py index d4d218b5702..6df84b6815a 100644 --- a/utils/lit/lit/TestingConfig.py +++ b/utils/lit/lit/TestingConfig.py @@ -9,7 +9,14 @@ class TestingConfig: """ @staticmethod - def frompath(path, parent, litConfig, mustExist, config = None): + def frompath(path, config, litConfig, mustExist): + """ + frompath(path, config, litConfig, mustExist) -> TestingConfig + + Load the configuration module at the provided path into the given config + object (or create a new one if None is provided) and return the config. + """ + if config is None: # Set the environment based on the command line arguments. environment = { @@ -38,7 +45,7 @@ class TestingConfig: if litConfig.valgrindLeakCheck: available_features.append('vg_leak') - config = TestingConfig(parent, + config = TestingConfig(None, name = '', suffixes = set(), test_format = None, diff --git a/utils/lit/lit/discovery.py b/utils/lit/lit/discovery.py index f76bd22075f..35b29c62d55 100644 --- a/utils/lit/lit/discovery.py +++ b/utils/lit/lit/discovery.py @@ -83,9 +83,8 @@ def getLocalConfig(ts, path_in_suite, litConfig, cache): cfgpath = os.path.join(source_path, litConfig.local_config_name) if litConfig.debug: litConfig.note('loading local config %r' % cfgpath) - return TestingConfig.frompath(cfgpath, parent, litConfig, - mustExist = False, - config = parent.clone(cfgpath)) + return TestingConfig.frompath(cfgpath, parent.clone(cfgpath), litConfig, + mustExist = False) def search(path_in_suite): key = (ts, path_in_suite)