RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

Reland [NewPM] Add OptimizationLevel param to registerPipelineStartEPCallback

Browse Source 
This allows targets to skip optional optimization passes at -O0.

Reviewed By: ychen

Differential Revision: https://reviews.llvm.org/D90777
This commit is contained in:
Arthur Eubanks 2020-11-04 10:14:37 -08:00
parent 3a6a4e9f83
commit b3f5096b36
4 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/llvm/Passes/PassBuilder.h
View File

@ -587,7 +587,7 @@ public:
/// pipeline. This does not apply to 'backend' compiles (LTO and ThinLTO /// pipeline. This does not apply to 'backend' compiles (LTO and ThinLTO
/// link-time pipelines). /// link-time pipelines).
void registerPipelineStartEPCallback( void registerPipelineStartEPCallback(
const std::function<void(ModulePassManager &)> &C) { const std::function<void(ModulePassManager &, OptimizationLevel)> &C) {
PipelineStartEPCallbacks.push_back(C); PipelineStartEPCallbacks.push_back(C);
} }
@ -722,7 +722,7 @@ private:
SmallVector<std::function<void(ModulePassManager &, OptimizationLevel)>, 2> SmallVector<std::function<void(ModulePassManager &, OptimizationLevel)>, 2>
OptimizerLastEPCallbacks; OptimizerLastEPCallbacks;
// Module callbacks // Module callbacks
SmallVector<std::function<void(ModulePassManager &)>, 2> SmallVector<std::function<void(ModulePassManager &, OptimizationLevel)>, 2>
PipelineStartEPCallbacks; PipelineStartEPCallbacks;
SmallVector<std::function<void(ModuleAnalysisManager &)>, 2> SmallVector<std::function<void(ModuleAnalysisManager &)>, 2>
ModuleAnalysisRegistrationCallbacks; ModuleAnalysisRegistrationCallbacks;

4
lib/Passes/PassBuilder.cpp
View File

@ -1319,7 +1319,7 @@ PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
// Apply module pipeline start EP callback. // Apply module pipeline start EP callback.
for (auto &C : PipelineStartEPCallbacks) for (auto &C : PipelineStartEPCallbacks)
C(MPM); C(MPM, Level);
if (PGOOpt && PGOOpt->SamplePGOSupport) if (PGOOpt && PGOOpt->SamplePGOSupport)
MPM.addPass(createModuleToFunctionPassAdaptor(AddDiscriminatorsPass())); MPM.addPass(createModuleToFunctionPassAdaptor(AddDiscriminatorsPass()));
@ -1348,7 +1348,7 @@ PassBuilder::buildThinLTOPreLinkDefaultPipeline(OptimizationLevel Level) {
// Apply module pipeline start EP callback. // Apply module pipeline start EP callback.
for (auto &C : PipelineStartEPCallbacks) for (auto &C : PipelineStartEPCallbacks)
C(MPM); C(MPM, Level);
// If we are planning to perform ThinLTO later, we don't bloat the code with // If we are planning to perform ThinLTO later, we don't bloat the code with
// unrolling/vectorization/... now. Just simplify the module as much as we // unrolling/vectorization/... now. Just simplify the module as much as we

13
lib/Target/BPF/BPFTargetMachine.cpp
View File

@ -125,12 +125,13 @@ void BPFTargetMachine::adjustPassManager(PassManagerBuilder &Builder) {
void BPFTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB, void BPFTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB,
bool DebugPassManager) { bool DebugPassManager) {
PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) { PB.registerPipelineStartEPCallback(
FunctionPassManager FPM(DebugPassManager); [=](ModulePassManager &MPM, PassBuilder::OptimizationLevel) {
FPM.addPass(BPFAbstractMemberAccessPass(this)); FunctionPassManager FPM(DebugPassManager);
FPM.addPass(BPFPreserveDITypePass()); FPM.addPass(BPFAbstractMemberAccessPass(this));
MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM))); FPM.addPass(BPFPreserveDITypePass());
}); MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
});
PB.registerPeepholeEPCallback([=](FunctionPassManager &FPM, PB.registerPeepholeEPCallback([=](FunctionPassManager &FPM,
PassBuilder::OptimizationLevel Level) { PassBuilder::OptimizationLevel Level) {
FPM.addPass(SimplifyCFGPass(SimplifyCFGOptions().hoistCommonInsts(true))); FPM.addPass(SimplifyCFGPass(SimplifyCFGOptions().hoistCommonInsts(true)));

9
tools/opt/NewPMDriver.cpp
View File

@ -190,10 +190,11 @@ static void registerEPCallbacks(PassBuilder &PB) {
Err(PB.parsePassPipeline(PM, VectorizerStartEPPipeline)); Err(PB.parsePassPipeline(PM, VectorizerStartEPPipeline));
}); });
if (tryParsePipelineText<ModulePassManager>(PB, PipelineStartEPPipeline)) if (tryParsePipelineText<ModulePassManager>(PB, PipelineStartEPPipeline))
PB.registerPipelineStartEPCallback([&PB](ModulePassManager &PM) { PB.registerPipelineStartEPCallback(
ExitOnError Err("Unable to parse PipelineStartEP pipeline: "); [&PB](ModulePassManager &PM, PassBuilder::OptimizationLevel) {
Err(PB.parsePassPipeline(PM, PipelineStartEPPipeline)); ExitOnError Err("Unable to parse PipelineStartEP pipeline: ");
}); Err(PB.parsePassPipeline(PM, PipelineStartEPPipeline));
});
if (tryParsePipelineText<FunctionPassManager>(PB, OptimizerLastEPPipeline)) if (tryParsePipelineText<FunctionPassManager>(PB, OptimizerLastEPPipeline))
PB.registerOptimizerLastEPCallback( PB.registerOptimizerLastEPCallback(
[&PB](ModulePassManager &PM, PassBuilder::OptimizationLevel) { [&PB](ModulePassManager &PM, PassBuilder::OptimizationLevel) {