RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

Linker: Split mapUnneededSubprograms into two; almost NFC

Browse Source 
Split the loop through compile units in mapUnneededSubprograms in two.
First, visit imported entities to ensure that we've visited all need
subprograms.  Second, visit subprograms, and drop the ones we don't
need.

Hypothetically this protects against a subprogram from one compile unit
being referenced from an imported entity in a different compile unit.  I
don't think that's valid IR (a debug info expert could confirm), but I
think the refactor makes the code more clear.

llvm-svn: 265233
This commit is contained in:
Duncan P. N. Exon Smith 2016-04-02 17:54:01 +00:00
parent 7a2147bcf0
commit b4a9af1e9d
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/Linker/IRMover.cpp
View File

@ -1040,22 +1040,26 @@ void IRLinker::mapUnneededSubprograms() {
NamedMDNode *CompileUnits = SrcM->getNamedMetadata("llvm.dbg.cu");
if (!CompileUnits)
return;
for (unsigned I = 0, E = CompileUnits->getNumOperands(); I != E; ++I) {
auto *CU = cast<DICompileUnit>(CompileUnits->getOperand(I));
// Seed the ValueMap with the imported entities, in case they reference new
// subprograms.
// FIXME: The DISubprogram for functions not linked in but kept due to
// being referenced by a DIImportedEntity should also get their
// IsDefinition flag is unset.
if (MDTuple *IEs = CU->getImportedEntities().get())
// Seed the ValueMap with the imported entities, in case they reference new
// subprograms.
// FIXME: The DISubprogram for functions not linked in but kept due to
// being referenced by a DIImportedEntity should also get their
// IsDefinition flag is unset.
for (unsigned I = 0, E = CompileUnits->getNumOperands(); I != E; ++I) {
if (MDTuple *IEs = cast<DICompileUnit>(CompileUnits->getOperand(I))
->getImportedEntities()
.get())
(void)MapMetadata(IEs, ValueMap,
ValueMapperFlags | RF_NullMapMissingGlobalValues,
&TypeMap, &GValMaterializer);
}
// Try to insert nullptr into the map for any SP not already mapped. If
// the insertion succeeds, we don't need this subprogram.
for (auto *Op : CU->getSubprograms())
// Try to insert nullptr into the map for any SP not already mapped. If
// the insertion succeeds, we don't need this subprogram.
for (unsigned I = 0, E = CompileUnits->getNumOperands(); I != E; ++I) {
for (auto *Op :
cast<DICompileUnit>(CompileUnits->getOperand(I))->getSubprograms())
if (ValueMap.MD().insert(std::make_pair(Op, TrackingMDRef())).second)
HasUnneededSPs = true;
}