RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[ThinLTO] Don't internalize during promotion

Browse Source 
Differential revision: https://reviews.llvm.org/D69107

llvm-svn: 375493
This commit is contained in:
Eugene Leviant 2019-10-22 09:24:12 +00:00
parent 5f98407da5
commit b54476ab94
3 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/Transforms/IPO/FunctionImport.cpp
View File

@ -952,6 +952,7 @@ void llvm::thinLTOResolvePrevailingInModule(
if (NewLinkage == GV.getLinkage())
return;
if (GlobalValue::isLocalLinkage(GV.getLinkage()) ||
GlobalValue::isLocalLinkage(NewLinkage) ||
// In case it was dead and already converted to declaration.
GV.isDeclaration())
return;

34
test/ThinLTO/X86/not-internalized.ll Normal file
View File

@ -0,0 +1,34 @@
; ModuleID = 'test.c'
source_filename = "test.c"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; RUN: opt -module-summary %s -o %t.bc
; RUN: llvm-lto2 run -save-temps %t.bc -o %t.out \
; RUN: -r=%t.bc,foo,plx \
; RUN: -r=%t.bc,bar,lx
; Check that we don't internalize `bar` during promotion,
; because foo and bar are members of the same comdat
; RUN: llvm-dis %t.out.1.1.promote.bc -o - | FileCheck %s
; Thin LTO internalization shouldn't internalize `bar` as well
; RUN: llvm-dis %t.out.1.2.internalize.bc -o - | FileCheck %s
; CHECK: define linkonce_odr dso_local i32 @bar() comdat($foo)
$foo = comdat any
; Function Attrs: noinline nounwind optnone uwtable
define linkonce_odr dso_local i32 @bar() comdat($foo) {
entry:
ret i32 33
}
; Function Attrs: noinline nounwind optnone uwtable
define linkonce_odr dso_local i32 @foo() comdat {
entry:
%call = call i32 @bar()
%add = add nsw i32 42, %call
ret i32 %add
}

4
test/ThinLTO/X86/weak_externals.ll
View File

@ -7,10 +7,12 @@
; RUN: -r=%t.bc,_ZZN9SingletonI1SE11getInstanceEvE8instance,lx \
; RUN: -r=%t.bc,_ZZN9SingletonI1SE11getInstanceEvE13instance_weak,lx
; RUN: llvm-dis %t.out.1.1.promote.bc -o - | FileCheck %s
; RUN: llvm-dis %t.out.1.2.internalize.bc -o - | FileCheck %s --check-prefix=INTERNALIZE
; CHECK: @_ZZN9SingletonI1SE11getInstanceEvE8instance = available_externally dso_local global %struct.S zeroinitializer
; CHECK: @_ZZN9SingletonI1SE11getInstanceEvE13instance_weak = available_externally dso_local global %struct.S* null, align 8
; CHECK: define internal dereferenceable(16) %struct.S* @_ZN9SingletonI1SE11getInstanceEv() comdat
; CHECK: define linkonce_odr dso_local dereferenceable(16) %struct.S* @_ZN9SingletonI1SE11getInstanceEv() comdat
; INTERNALIZE: define internal dereferenceable(16) %struct.S* @_ZN9SingletonI1SE11getInstanceEv()
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"