RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 11:13:28 +01:00
Code Issues Projects Releases Wiki Activity

Revert "Fix crash when multiple raw_fd_ostreams to stdout are created."

Browse Source 
This reverts commit r297624.
It was failing on the bots.

llvm-svn: 297657
This commit is contained in:
Rafael Espindola 2017-03-13 19:38:32 +00:00
parent 58f8a88d1e
commit b89a1dbe86
3 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Support/raw_ostream.cpp
View File

@ -473,7 +473,7 @@ static int getFD(StringRef Filename, std::error_code &EC,
// possible.
if (!(Flags & sys::fs::F_Text))
sys::ChangeStdoutToBinary();
return dup(STDOUT_FILENO);
return STDOUT_FILENO;
}
int FD;

14
test/Other/writing-to-stdout.ll
View File

@ -1,14 +0,0 @@
; Often LLVM tools use "-" to indicate that output should be written to stdout
; instead of a file. This behaviour is implemented by the raw_fd_ostream class.
; This test verifies that when doing so multiple times we don't try to access a
; closed STDOUT_FILENO. The exact options used in this test are unimportant, as
; long as they write to stdout using raw_fd_ostream.
; RUN: llc %s -o=- -pass-remarks-output=- -filetype=asm | FileCheck %s
; foobar should appear as a function somewhere in the assembly file.
; CHECK: foobar
; !Analysis appears at the start of pass-remarks-output.
; CHECK: !Analysis
define void @foobar() {
ret void
}

8
unittests/Support/raw_ostream_test.cpp
View File

@ -9,7 +9,6 @@
#include "gtest/gtest.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Format.h"
#include "llvm/Support/raw_ostream.h"
@ -331,11 +330,4 @@ TEST(raw_ostreamTest, FormattedHexBytes) {
"0007: 68 69 6a 6b 6c |hijkl|",
format_bytes_with_ascii_str(B.take_front(12), 0, 7, 1));
}
TEST(raw_fd_ostreamTest, multiple_raw_fd_ostream_to_stdout) {
std::error_code EC;
{ raw_fd_ostream("-", EC, sys::fs::OpenFlags::F_None); }
{ raw_fd_ostream("-", EC, sys::fs::OpenFlags::F_None); }
}
}