1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00

Revert "lit.py: Add new %{shared_output(LABEL)} substitution"

This reverts r315697 and my ill-fated attempts to fix it on Windows.
I'll try again when I get access to a Windows machine.

llvm-svn: 315793
This commit is contained in:
Jordan Rose 2017-10-14 04:01:27 +00:00
parent d7b4ac5704
commit b9755eaa6d
9 changed files with 11 additions and 56 deletions

View File

@ -395,18 +395,17 @@ PRE-DEFINED SUBSTITUTIONS
:program:`lit` provides various patterns that can be used with the RUN command. :program:`lit` provides various patterns that can be used with the RUN command.
These are defined in TestRunner.py. The base set of substitutions are: These are defined in TestRunner.py. The base set of substitutions are:
======================= ============== ========== ==============
Macro Substitution Macro Substitution
======================= ============== ========== ==============
%s source path (path to the file currently being run) %s source path (path to the file currently being run)
%S source dir (directory of the file currently being run) %S source dir (directory of the file currently being run)
%p same as %S %p same as %S
%{pathsep} path separator %{pathsep} path separator
%t temporary file name unique to the test %t temporary file name unique to the test
%T temporary directory unique to the test %T temporary directory unique to the test
%{shared_output(LABEL)} temporary file name, identified by "LABEL", shared across all tests %% %
%% % ========== ==============
======================= ==============
Other substitutions are provided that are variations on this base set and Other substitutions are provided that are variations on this base set and
further substitution patterns can be defined by each test module. See the further substitution patterns can be defined by each test module. See the

View File

@ -464,12 +464,6 @@ RUN lines:
Example: ``/home/user/llvm.build/test/MC/ELF/Output`` Example: ``/home/user/llvm.build/test/MC/ELF/Output``
``%{shared_output(LABEL)}``
File path to a temporary file name shared across all tests, identified by
LABEL. This is useful as a cache for generated resources.
Example: ``/home/user/llvm.build/test/Output/Shared/LABEL.tmp``
``%{pathsep}`` ``%{pathsep}``
Expands to the path separator, i.e. ``:`` (or ``;`` on Windows). Expands to the path separator, i.e. ``:`` (or ``;`` on Windows).

View File

@ -829,9 +829,6 @@ def getDefaultSubstitutions(test, tmpDir, tmpBase, normalize_slashes=False):
sourcepath = test.getSourcePath() sourcepath = test.getSourcePath()
sourcedir = os.path.dirname(sourcepath) sourcedir = os.path.dirname(sourcepath)
sharedOutputDir = os.path.join(test.suite.exec_root, 'Output', 'Shared')
sharedOutputDir += os.path.sep
# Normalize slashes, if requested. # Normalize slashes, if requested.
if normalize_slashes: if normalize_slashes:
sourcepath = sourcepath.replace('\\', '/') sourcepath = sourcepath.replace('\\', '/')
@ -852,8 +849,6 @@ def getDefaultSubstitutions(test, tmpDir, tmpBase, normalize_slashes=False):
('%t', tmpName), ('%t', tmpName),
('%basename_t', baseName), ('%basename_t', baseName),
('%T', tmpDir), ('%T', tmpDir),
('%{shared_output\(([-+=._a-zA-Z0-9]+)\)}',
'%s\\1.tmp' % (sharedOutputDir,)),
('#_MARKER_#', '%')]) ('#_MARKER_#', '%')])
# "%/[STpst]" should be normalized. # "%/[STpst]" should be normalized.

View File

@ -1,5 +1,4 @@
import os import os
import shutil
import sys import sys
import threading import threading
import time import time
@ -137,13 +136,6 @@ class Run(object):
return True return True
win32api.SetConsoleCtrlHandler(console_ctrl_handler, True) win32api.SetConsoleCtrlHandler(console_ctrl_handler, True)
# Make fresh shared output directories.
suites = set(test.suite for test in self.tests)
for suite in suites:
shared_dir = os.path.join(suite.exec_root, 'Output', 'Shared')
shutil.rmtree(shared_dir, ignore_errors=True)
lit.util.mkdir_p(shared_dir)
# Save the display object on the runner so that we can update it from # Save the display object on the runner so that we can update it from
# our task completion callback. # our task completion callback.
self.display = display self.display = display

View File

@ -1,5 +0,0 @@
import lit.formats
config.name = 'shared-output'
config.suffixes = ['.txt']
config.test_format = lit.formats.ShTest()
config.test_source_root = os.path.dirname(os.path.realpath(__file__))

View File

@ -1,2 +0,0 @@
RUN: echo "primary" >> %{shared_output(SHARED)}
RUN: echo "other" >> %{shared_output(OTHER)}

View File

@ -1 +0,0 @@
RUN: echo "secondary" >> %{shared_output(SHARED)}

View File

@ -1 +0,0 @@
RUN: echo "sub" >> %{shared_output(SHARED)}

View File

@ -1,16 +0,0 @@
# XFAIL: windows
# Still need to work out some path issues
# RUN: rm -rf %t && mkdir -p %t
# RUN: echo 'lit_config.load_config(config, os.path.join(r"%{inputs}", "shared-output", "lit.cfg"))' > %t/lit.site.cfg
# RUN: %{lit} %t
# RUN: FileCheck %s < %t/Output/Shared/SHARED.tmp
# RUN: FileCheck -check-prefix=NEGATIVE %s < %t/Output/Shared/SHARED.tmp
# RUN: FileCheck -check-prefix=OTHER %s < %t/Output/Shared/OTHER.tmp
# CHECK-DAG: primary
# CHECK-DAG: secondary
# CHECK-DAG: sub
# NEGATIVE-NOT: other
# OTHER: other