RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 19:52:54 +01:00
Code Issues Projects Releases Wiki Activity

[MemorySSA] Fix use of pointsToConstantMemory in isUseTriviallyOptimizableToLiveOnEntry

Browse Source 
In isUseTriviallyOptimizableToLiveOnEntry, pointsToConstantMemory needs to be
called on the load's pointer operand, not on the result of the load (which
might not even be a pointer).

llvm-svn: 299823
This commit is contained in:
Hal Finkel 2017-04-09 12:57:50 +00:00
parent d3f5309a19
commit bbc0d938fc
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Transforms/Utils/MemorySSA.cpp
View File

@ -316,7 +316,8 @@ static bool isUseTriviallyOptimizableToLiveOnEntry(AliasAnalysis &AA,
// FIXME: We should handle invariant groups, as well. It's a bit harder,
// because we need to pay close attention to invariant group barriers.
return isa<LoadInst>(I) && (I->getMetadata(LLVMContext::MD_invariant_load) ||
AA.pointsToConstantMemory(I));
AA.pointsToConstantMemory(cast<LoadInst>(I)->
getPointerOperand()));
}
/// Verifies that `Start` is clobbered by `ClobberAt`, and that nothing

23
test/Transforms/Util/MemorySSA/ptr-const-mem.ll Normal file
View File

@ -0,0 +1,23 @@
; RUN: opt -basicaa -print-memoryssa -verify-memoryssa -analyze -memssa-check-limit=0 < %s 2>&1 | FileCheck %s
; RUN: opt -aa-pipeline=basic-aa -passes='print<memoryssa>' -verify-memoryssa -disable-output -memssa-check-limit=0 < %s 2>&1 | FileCheck %s
target datalayout = "e-p:32:32-p1:64:64-p2:64:64-p3:32:32-p4:64:64-p5:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64"
target triple = "amdgcn"
@g4 = external unnamed_addr constant i8, align 1
define signext i8 @cmp_constant(i8* %q, i8 %v) local_unnamed_addr {
entry:
store i8 %v, i8* %q, align 1
; CHECK: 1 = MemoryDef(liveOnEntry)
; CHECK-NEXT: store i8 %v, i8* %q, align 1
%0 = load i8, i8* @g4, align 1
; Make sure that this load is liveOnEntry just based on the fact that @g4 is
; constant memory.
; CHECK: MemoryUse(liveOnEntry)
; CHECK-NEXT: load i8, i8* @g4, align 1
ret i8 %0
}