mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 19:12:56 +02:00
[CodeGen] Fix warnings in sve-ld1-addressing-mode-reg-imm.ll
For the GetElementPtr case in function AddressingModeMatcher::matchOperationAddr I've changed the code to use the TypeSize class instead of relying upon the implicit conversion to a uint64_t. As part of this we now check for scalable types and if we encounter one just bail out for now as the subsequent optimisations doesn't currently support them. This changes fixes up all warnings in the following tests: llvm/test/CodeGen/AArch64/sve-ld1-addressing-mode-reg-imm.ll llvm/test/CodeGen/AArch64/sve-st1-addressing-mode-reg-imm.ll Differential Revision: https://reviews.llvm.org/D83124
This commit is contained in:
parent
07746c07ec
commit
bd3697d837
@ -4356,15 +4356,20 @@ bool AddressingModeMatcher::matchOperationAddr(User *AddrInst, unsigned Opcode,
|
||||
cast<ConstantInt>(AddrInst->getOperand(i))->getZExtValue();
|
||||
ConstantOffset += SL->getElementOffset(Idx);
|
||||
} else {
|
||||
uint64_t TypeSize = DL.getTypeAllocSize(GTI.getIndexedType());
|
||||
if (ConstantInt *CI = dyn_cast<ConstantInt>(AddrInst->getOperand(i))) {
|
||||
const APInt &CVal = CI->getValue();
|
||||
if (CVal.getMinSignedBits() <= 64) {
|
||||
ConstantOffset += CVal.getSExtValue() * TypeSize;
|
||||
continue;
|
||||
TypeSize TS = DL.getTypeAllocSize(GTI.getIndexedType());
|
||||
if (TS.isNonZero()) {
|
||||
// The optimisations below currently only work for fixed offsets.
|
||||
if (TS.isScalable())
|
||||
return false;
|
||||
int64_t TypeSize = TS.getFixedSize();
|
||||
if (ConstantInt *CI =
|
||||
dyn_cast<ConstantInt>(AddrInst->getOperand(i))) {
|
||||
const APInt &CVal = CI->getValue();
|
||||
if (CVal.getMinSignedBits() <= 64) {
|
||||
ConstantOffset += CVal.getSExtValue() * TypeSize;
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
if (TypeSize) { // Scales of zero don't do anything.
|
||||
// We only allow one variable index at the moment.
|
||||
if (VariableOperand != -1)
|
||||
return false;
|
||||
|
@ -1,5 +1,8 @@
|
||||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
||||
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
|
||||
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>%t | FileCheck %s
|
||||
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
|
||||
|
||||
; WARN-NOT: warning
|
||||
|
||||
; LD1B
|
||||
|
||||
|
@ -1,5 +1,8 @@
|
||||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
||||
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
|
||||
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>%t | FileCheck %s
|
||||
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
|
||||
|
||||
; WARN-NOT: warning
|
||||
|
||||
; ST1B
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user