RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 20:23:11 +01:00
Code Issues Projects Releases Wiki Activity

[llvm][NFC][CallSite] Remove CallSite from Lint.cpp

Browse Source 
Summary: The CallSite arg iterator is really User::op_iterator.

Reviewers: dblaikie, craig.topper

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78507
This commit is contained in:
Mircea Trofin 2020-04-20 10:28:11 -07:00
parent 062f8cacd4
commit be64b760d9
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Analysis/Lint.cpp
View File

@ -49,7 +49,6 @@
#include "llvm/Analysis/ValueTracking.h" #include "llvm/Analysis/ValueTracking.h"
#include "llvm/IR/Argument.h" #include "llvm/IR/Argument.h"
#include "llvm/IR/BasicBlock.h" #include "llvm/IR/BasicBlock.h"
#include "llvm/IR/CallSite.h"
#include "llvm/IR/Constant.h" #include "llvm/IR/Constant.h"
#include "llvm/IR/Constants.h" #include "llvm/IR/Constants.h"
#include "llvm/IR/DataLayout.h" #include "llvm/IR/DataLayout.h"
@ -249,7 +248,7 @@ void Lint::visitCallBase(CallBase &I) {
// Check argument types (in case the callee was casted) and attributes. // Check argument types (in case the callee was casted) and attributes.
// TODO: Verify that caller and callee attributes are compatible. // TODO: Verify that caller and callee attributes are compatible.
Function::arg_iterator PI = F->arg_begin(), PE = F->arg_end(); Function::arg_iterator PI = F->arg_begin(), PE = F->arg_end();
CallSite::arg_iterator AI = I.arg_begin(), AE = I.arg_end(); auto AI = I.arg_begin(), AE = I.arg_end();
for (; AI != AE; ++AI) { for (; AI != AE; ++AI) {
Value *Actual = *AI; Value *Actual = *AI;
if (PI != PE) { if (PI != PE) {
@ -265,8 +264,7 @@ void Lint::visitCallBase(CallBase &I) {
if (Formal->hasNoAliasAttr() && Actual->getType()->isPointerTy()) { if (Formal->hasNoAliasAttr() && Actual->getType()->isPointerTy()) {
AttributeList PAL = I.getAttributes(); AttributeList PAL = I.getAttributes();
unsigned ArgNo = 0; unsigned ArgNo = 0;
for (CallSite::arg_iterator BI = I.arg_begin(); BI != AE; for (auto BI = I.arg_begin(); BI != AE; ++BI, ++ArgNo) {
++BI, ++ArgNo) {
// Skip ByVal arguments since they will be memcpy'd to the callee's // Skip ByVal arguments since they will be memcpy'd to the callee's
// stack so we're not really passing the pointer anyway. // stack so we're not really passing the pointer anyway.
if (PAL.hasParamAttribute(ArgNo, Attribute::ByVal)) if (PAL.hasParamAttribute(ArgNo, Attribute::ByVal))