From c18f3838598814cf253fd247ee2e58fde2c057ae Mon Sep 17 00:00:00 2001 From: Michael Kruse Date: Fri, 14 Dec 2018 18:15:11 +0000 Subject: [PATCH] [Transforms] Preserve metadata when converting invoke to call. The `changeToCall` function did not preserve the invoke's metadata. Currently, there is probably no metadata that depends on being applied on a CallInst or InvokeInst. Therefore we can replace the instruction's metadata. This fixes http://llvm.org/PR39994 Suggested-by: Moritz Kreutzer Differential Revision: https://reviews.llvm.org/D55666 llvm-svn: 349170 --- lib/Transforms/Utils/Local.cpp | 1 + test/Transforms/PruneEH/looptest.ll | 44 +++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 test/Transforms/PruneEH/looptest.ll diff --git a/lib/Transforms/Utils/Local.cpp b/lib/Transforms/Utils/Local.cpp index 2b7d7ad9d4d..fa0151dbd9f 100644 --- a/lib/Transforms/Utils/Local.cpp +++ b/lib/Transforms/Utils/Local.cpp @@ -1970,6 +1970,7 @@ static void changeToCall(InvokeInst *II, DomTreeUpdater *DTU = nullptr) { NewCall->setCallingConv(II->getCallingConv()); NewCall->setAttributes(II->getAttributes()); NewCall->setDebugLoc(II->getDebugLoc()); + NewCall->copyMetadata(*II); II->replaceAllUsesWith(NewCall); // Follow the call by a branch to the normal destination. diff --git a/test/Transforms/PruneEH/looptest.ll b/test/Transforms/PruneEH/looptest.ll new file mode 100644 index 00000000000..2729ec933ca --- /dev/null +++ b/test/Transforms/PruneEH/looptest.ll @@ -0,0 +1,44 @@ +; RUN: opt < %s -prune-eh -S | FileCheck %s + +declare void @nounwind() nounwind + +define internal void @foo() { + call void @nounwind() + ret void +} + +; CHECK-LABEL: @caller +define i32 @caller(i32 %n) personality i32 (...)* @__gxx_personality_v0 { +entry: + br label %for + +for: + %j = phi i32 [0, %entry], [%j.inc, %inc] + %j.cmp = icmp slt i32 %j, %n + br i1 %j.cmp, label %body, label %exit, !llvm.loop !0 + +body: +; CHECK: call void @foo(), !llvm.mem.parallel_loop_access !0 + invoke void @foo( ) + to label %Normal unwind label %Except, !llvm.mem.parallel_loop_access !0 + br label %inc + +inc: + %j.inc = add nuw nsw i32 %j, 1 + br label %for, !llvm.loop !0 + +exit: + br label %Normal + +Normal: + ret i32 0 + +Except: + landingpad { i8*, i32 } + catch i8* null + ret i32 1 +} + +declare i32 @__gxx_personality_v0(...) + +!0 = distinct !{!0}