RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 19:12:56 +02:00
Code Issues Projects Releases Wiki Activity

X86: Wrap a helper for an assert in #ifndef NDEBUG

Browse Source 
This function is used in exactly one place, and only in asserts
builds. Move it a few lines up before the use and only define it when
asserts are enabled. Fixes the release build under -Werror.

Also remove the forward declaration and commentary that was basically
identical to the code itself.

llvm-svn: 261722
This commit is contained in:
Justin Bogner 2016-02-24 07:58:02 +00:00
parent 6c6bd4573e
commit c26c003b44
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/Target/X86/X86OptimizeLEAs.cpp
View File

@ -60,12 +60,6 @@ static inline bool isIdenticalOp(const MachineOperand &MO1,
static bool isSimilarDispOp(const MachineOperand &MO1,
const MachineOperand &MO2);
/// \brief Returns true if the type of \p MO is valid for address displacement
/// operand. According to X86DAGToDAGISel::getAddressOperands allowed types are:
/// MO_Immediate, MO_ConstantPoolIndex, MO_JumpTableIndex, MO_ExternalSymbol,
/// MO_GlobalAddress, MO_BlockAddress or MO_MCSymbol.
static inline bool isValidDispOp(const MachineOperand &MO);
/// \brief Returns true if the instruction is LEA.
static inline bool isLEA(const MachineInstr &MI);
@ -188,6 +182,13 @@ static inline bool isIdenticalOp(const MachineOperand &MO1,
!TargetRegisterInfo::isPhysicalRegister(MO1.getReg()));
}
#ifndef NDEBUG
static bool isValidDispOp(const MachineOperand &MO) {
return MO.isImm() || MO.isCPI() || MO.isJTI() || MO.isSymbol() ||
MO.isGlobal() || MO.isBlockAddress() || MO.isMCSymbol();
}
#endif
static bool isSimilarDispOp(const MachineOperand &MO1,
const MachineOperand &MO2) {
assert(isValidDispOp(MO1) && isValidDispOp(MO2) &&
@ -205,11 +206,6 @@ static bool isSimilarDispOp(const MachineOperand &MO1,
MO1.getMCSymbol() == MO2.getMCSymbol());
}
static inline bool isValidDispOp(const MachineOperand &MO) {
return MO.isImm() || MO.isCPI() || MO.isJTI() || MO.isSymbol() ||
MO.isGlobal() || MO.isBlockAddress() || MO.isMCSymbol();
}
static inline bool isLEA(const MachineInstr &MI) {
unsigned Opcode = MI.getOpcode();
return Opcode == X86::LEA16r || Opcode == X86::LEA32r ||