RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

[ARM] Use a Changed flag to avoid making a pass's return value dependent on a compare with a Statistic object.

Browse Source 
Statistic compile to always be 0 in release build so this compare would always return false. And in the debug builds Statistic are global variables and remember their values across pass runs. So this compare returns true anytime the pass runs after the first time it modifies something.

This was found after reviewing all usages of comparison operators on a Statistic object. We had some internal code that did a compare with a statistic that caused a mismatch in output between debug and release builds. So we did an audit out of paranoia.

llvm-svn: 302450
This commit is contained in:
Craig Topper 2017-05-08 18:02:51 +00:00
parent 1de743647f
commit c6a3bfadb3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Target/ARM/ARMOptimizeBarriersPass.cpp
View File

@ -88,13 +88,15 @@ bool ARMOptimizeBarriersPass::runOnMachineFunction(MachineFunction &MF) {
} }
} }
} }
bool Changed = false;
// Remove the tagged DMB // Remove the tagged DMB
for (auto MI : ToRemove) { for (auto MI : ToRemove) {
MI->eraseFromParent(); MI->eraseFromParent();
++NumDMBsRemoved; ++NumDMBsRemoved;
Changed = true;
} }
return NumDMBsRemoved > 0; return Changed;
} }
/// createARMOptimizeBarriersPass - Returns an instance of the remove double /// createARMOptimizeBarriersPass - Returns an instance of the remove double