diff --git a/lib/Transforms/Scalar/JumpThreading.cpp b/lib/Transforms/Scalar/JumpThreading.cpp index 327a1a6f2e7..a9a0070c1d5 100644 --- a/lib/Transforms/Scalar/JumpThreading.cpp +++ b/lib/Transforms/Scalar/JumpThreading.cpp @@ -2833,6 +2833,16 @@ bool JumpThreadingPass::TryToUnfoldSelect(CmpInst *CondCmp, BasicBlock *BB) { /// select is not jump-threaded, it will be folded again in the later /// optimizations. bool JumpThreadingPass::TryToUnfoldSelectInCurrBB(BasicBlock *BB) { + // This transform can introduce a UB (a conditional branch that depends on a + // poison value) that was not present in the original program. See + // @TryToUnfoldSelectInCurrBB test in test/Transforms/JumpThreading/select.ll. + // Disable this transform under MemorySanitizer. + // FIXME: either delete it or replace with a valid transform. This issue is + // not limited to MemorySanitizer (but has only been observed as an MSan false + // positive in practice so far). + if (BB->getParent()->hasFnAttribute(Attribute::SanitizeMemory)) + return false; + // If threading this would thread across a loop header, don't thread the edge. // See the comments above FindLoopHeaders for justifications and caveats. if (LoopHeaders.count(BB)) diff --git a/test/Transforms/JumpThreading/select-unfold-msan.ll b/test/Transforms/JumpThreading/select-unfold-msan.ll new file mode 100644 index 00000000000..ea336e0f0f7 --- /dev/null +++ b/test/Transforms/JumpThreading/select-unfold-msan.ll @@ -0,0 +1,28 @@ +; PR45220 +; RUN: opt -S -jump-threading < %s | FileCheck %s + +declare i1 @NOP() + +define dso_local i32 @f(i1 %b, i1 %u) sanitize_memory { +entry: + br i1 %b, label %if.end, label %if.else + +if.else: + %call = call i1 @NOP() + br label %if.end + +if.end: +; Check that both selects in this BB are still in place, +; and were not replaced with a conditional branch. +; CHECK: phi +; CHECK-NEXT: phi +; CHECK-NEXT: select +; CHECK-NEXT: select +; CHECK-NEXT: ret + %u1 = phi i1 [ true, %if.else ], [ %u, %entry ] + %v = phi i1 [ %call, %if.else ], [ false, %entry ] + %s = select i1 %u1, i32 22, i32 0 + %v1 = select i1 %v, i32 %s, i32 42 + ret i32 %v1 +} +