RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 11:02:59 +02:00
Code Issues Projects Releases Wiki Activity

Fix size computation of array allocation in inline cost analysis

Browse Source 
Differential revision: http://reviews.llvm.org/D21690

llvm-svn: 273952
This commit is contained in:
Easwaran Raman 2016-06-27 22:31:53 +00:00
parent 88dfc37dab
commit ca6b4c3c82
2 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Analysis/InlineCost.cpp
View File

@ -339,9 +339,10 @@ bool CallAnalyzer::visitAlloca(AllocaInst &I) {
if (I.isArrayAllocation()) {
Constant *Size = SimplifiedValues.lookup(I.getArraySize());
if (auto *AllocSize = dyn_cast_or_null<ConstantInt>(Size)) {
const DataLayout &DL = F.getParent()->getDataLayout();
Type *Ty = I.getAllocatedType();
// FIXME: This can't be right. AllocatedSize is in *bytes*.
AllocatedSize += Ty->getPrimitiveSizeInBits() * AllocSize->getZExtValue();
AllocatedSize = SaturatingMultiplyAdd(
AllocSize->getLimitedValue(), DL.getTypeAllocSize(Ty), AllocatedSize);
return Base::visitAlloca(I);
}
}
@ -350,7 +351,7 @@ bool CallAnalyzer::visitAlloca(AllocaInst &I) {
if (I.isStaticAlloca()) {
const DataLayout &DL = F.getParent()->getDataLayout();
Type *Ty = I.getAllocatedType();
AllocatedSize += DL.getTypeAllocSize(Ty);
AllocatedSize = SaturatingAdd(DL.getTypeAllocSize(Ty), AllocatedSize);
}
// We will happily inline static alloca instructions.

36
test/Transforms/Inline/array-alloca.ll Normal file
View File

@ -0,0 +1,36 @@
; RUN: opt -inline -S < %s | FileCheck %s
%struct.A = type { i32 }
define void @callee1(i32 %M) {
entry:
%vla = alloca i32, i32 %M, align 16
ret void
}
define void @callee2(i32 %M) {
entry:
%vla = alloca %struct.A, i32 %M, align 16
ret void
}
define void @callee3(i128 %M) {
entry:
%vla = alloca i32, i128 %M, align 16
ret void
}
; CHECK-LABEL: @caller
define void @caller() #0 {
entry:
call void @caller()
; CHECK-NOT: call void @callee1
call void @callee1(i32 256)
; CHECK: call void @callee2
call void @callee2(i32 4096)
; CHECK: call void @callee3
; This is to test that there is no overflow in computing allocated size
; call void @callee3(i128 0x8000000000000000);
call void @callee3(i128 9223372036854775808);
ret void
}