RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 11:13:28 +01:00
Code Issues Projects Releases Wiki Activity

[unittest] Remove TODO comment which caused concern

Browse Source 
Remove the second part of the TODO comment that highlighted an issue with
possibly connecting all nodes to the exit of the CFG. This caused concerns
with Jakub Kuderski regarding its feasability, hence we remove it. Such
points are better discussed outside of CFG. If connecting all nodes makes
sense and what the impact is is currently part of an active review discussion.

llvm-svn: 309919
This commit is contained in:
Tobias Grosser 2017-08-03 04:17:58 +00:00
parent 85be51d9ca
commit d257077fd2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unittests/IR/DominatorTreeTest.cpp
View File

@ -454,7 +454,7 @@ TEST(DominatorTree, DeletingEdgesIntroducesUnreachables) {
// PDT. We also verify this property.
//
// TODO: Can we change the PDT definition such that C remains part of the
// CFG, at best without loosing the dominance relation D postdom B.
// CFG?
TEST(DominatorTree, DeletingEdgesIntroducesInfiniteLoop) {
StringRef ModuleString =
"define void @f() {\n"