RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-18 10:32:48 +02:00
Code Issues Projects Releases Wiki Activity

[ORC][C-bindings] Re-order object transform function arguments.

Browse Source 
ObjInOut is an in-out parameter not a return value argument, so by convention
it should come after the context value (Ctx).
This commit is contained in:
Lang Hames 2021-06-18 22:12:39 +10:00
parent eb023bd323
commit d2647ecc04
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/OrcV2Examples/OrcV2CBindingsDumpObjects/OrcV2CBindingsDumpObjects.c
View File

@ -51,7 +51,7 @@ LLVMOrcThreadSafeModuleRef createDemoModule() {
return TSM; return TSM;
} }
LLVMErrorRef dumpObjectsTransform(LLVMMemoryBufferRef *ObjInOut, void *Ctx) { LLVMErrorRef dumpObjectsTransform(void *Ctx, LLVMMemoryBufferRef *ObjInOut) {
LLVMOrcDumpObjectsRef DumpObjects = *(LLVMOrcDumpObjectsRef *)Ctx; LLVMOrcDumpObjectsRef DumpObjects = *(LLVMOrcDumpObjectsRef *)Ctx;
return LLVMOrcDumpObjects_CallOperator(DumpObjects, ObjInOut); return LLVMOrcDumpObjects_CallOperator(DumpObjects, ObjInOut);
} }

2
include/llvm-c/Orc.h
View File

@ -328,7 +328,7 @@ typedef struct LLVMOrcOpaqueObjectTransformLayer
* buffer should be disposed of and set to null. * buffer should be disposed of and set to null.
*/ */
typedef LLVMErrorRef (*LLVMOrcObjectTransformLayerTransformFunction)( typedef LLVMErrorRef (*LLVMOrcObjectTransformLayerTransformFunction)(
LLVMMemoryBufferRef *ObjInOut, void *Ctx); void *Ctx, LLVMMemoryBufferRef *ObjInOut);
/** /**
* A reference to an orc::DumpObjects object. * A reference to an orc::DumpObjects object.

2
lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
View File

@ -524,7 +524,7 @@ void LLVMOrcObjectTransformLayerSetTransform(
->setTransform([TransformFunction, Ctx](std::unique_ptr<MemoryBuffer> Obj) ->setTransform([TransformFunction, Ctx](std::unique_ptr<MemoryBuffer> Obj)
-> Expected<std::unique_ptr<MemoryBuffer>> { -> Expected<std::unique_ptr<MemoryBuffer>> {
LLVMMemoryBufferRef ObjBuffer = wrap(Obj.release()); LLVMMemoryBufferRef ObjBuffer = wrap(Obj.release());
if (LLVMErrorRef Err = TransformFunction(&ObjBuffer, Ctx)) { if (LLVMErrorRef Err = TransformFunction(Ctx, &ObjBuffer)) {
assert(!ObjBuffer && "ObjBuffer was not reset to null on error"); assert(!ObjBuffer && "ObjBuffer was not reset to null on error");
return unwrap(Err); return unwrap(Err);
} }