RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 20:23:11 +01:00
Code Issues Projects Releases Wiki Activity

Refactor Threshold computation. NFC.

Browse Source 
This is part of changes reviewed in http://reviews.llvm.org/D17584.

llvm-svn: 265852
This commit is contained in:
Easwaran Raman 2016-04-08 21:28:02 +00:00
parent 8cac1d5c28
commit d28bd252a2
1 changed files with 35 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
lib/Analysis/InlineCost.cpp
View File

@ -154,6 +154,9 @@ class CallAnalyzer : public InstVisitor<CallAnalyzer, bool> {
/// analysis. /// analysis.
void updateThreshold(CallSite CS, Function &Callee); void updateThreshold(CallSite CS, Function &Callee);
/// Return true if size growth is allowed when inlining the callee at CS.
bool allowSizeGrowth(CallSite CS);
// Custom analysis routines. // Custom analysis routines.
bool analyzeBlock(BasicBlock *BB, SmallPtrSetImpl<const Value *> &EphValues); bool analyzeBlock(BasicBlock *BB, SmallPtrSetImpl<const Value *> &EphValues);
@ -572,7 +575,39 @@ bool CallAnalyzer::isKnownNonNullInCallee(Value *V) {
return false; return false;
} }
bool CallAnalyzer::allowSizeGrowth(CallSite CS) {
// If the normal destination of the invoke or the parent block of the call
// site is unreachable-terminated, there is little point in inlining this
// unless there is literally zero cost.
// FIXME: Note that it is possible that an unreachable-terminated block has a
// hot entry. For example, in below scenario inlining hot_call_X() may be
// beneficial :
// main() {
// hot_call_1();
// ...
// hot_call_N()
// exit(0);
// }
// For now, we are not handling this corner case here as it is rare in real
// code. In future, we should elaborate this based on BPI and BFI in more
// general threshold adjusting heuristics in updateThreshold().
Instruction *Instr = CS.getInstruction();
if (InvokeInst *II = dyn_cast<InvokeInst>(Instr)) {
if (isa<UnreachableInst>(II->getNormalDest()->getTerminator()))
return false;
} else if (isa<UnreachableInst>(Instr->getParent()->getTerminator()))
return false;
return true;
}
void CallAnalyzer::updateThreshold(CallSite CS, Function &Callee) { void CallAnalyzer::updateThreshold(CallSite CS, Function &Callee) {
// If no size growth is allowed for this inlining, set Threshold to 0.
if (!allowSizeGrowth(CS)) {
Threshold = 0;
return;
}
// If -inline-threshold is not given, listen to the optsize and minsize // If -inline-threshold is not given, listen to the optsize and minsize
// attributes when they would decrease the threshold. // attributes when they would decrease the threshold.
Function *Caller = CS.getCaller(); Function *Caller = CS.getCaller();
@ -1214,28 +1249,6 @@ bool CallAnalyzer::analyzeCall(CallSite CS) {
if (OnlyOneCallAndLocalLinkage) if (OnlyOneCallAndLocalLinkage)
Cost += InlineConstants::LastCallToStaticBonus; Cost += InlineConstants::LastCallToStaticBonus;
// If the normal destination of the invoke or the parent block of the call
// site is unreachable-terminated, there is little point in inlining this
// unless there is literally zero cost.
// FIXME: Note that it is possible that an unreachable-terminated block has a
// hot entry. For example, in below scenario inlining hot_call_X() may be
// beneficial :
// main() {
// hot_call_1();
// ...
// hot_call_N()
// exit(0);
// }
// For now, we are not handling this corner case here as it is rare in real
// code. In future, we should elaborate this based on BPI and BFI in more
// general threshold adjusting heuristics in updateThreshold().
Instruction *Instr = CS.getInstruction();
if (InvokeInst *II = dyn_cast<InvokeInst>(Instr)) {
if (isa<UnreachableInst>(II->getNormalDest()->getTerminator()))
Threshold = 0;
} else if (isa<UnreachableInst>(Instr->getParent()->getTerminator()))
Threshold = 0;
// If this function uses the coldcc calling convention, prefer not to inline // If this function uses the coldcc calling convention, prefer not to inline
// it. // it.
if (F.getCallingConv() == CallingConv::Cold) if (F.getCallingConv() == CallingConv::Cold)