mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 02:33:06 +01:00
llvm-objcopy: fix section size truncation/extension when dumping sections
Since this only comes up with inputs containing sections at least 4GB large (I guess I could use a bzero section or something, so the input file doesn't have to be 4GB, but even then the output file would have to be 4GB, right?) I've skipped testing this. If there's a nice way to test this without needing 4GB inputs or output files. The subtlety here is demonstrated by this code: struct t { operator uint64_t(); }; static_assert(std::is_same_v<int, decltype(std::declval<bool>() ? 0 : std::declval<t>())>); static_assert(std::is_same_v<uint64_t, decltype(std::declval<bool>() ? 0 : std::declval<uint64_t>())>); Because of this difference, the original source code was getting an int type (truncating the actual size) and then extending it again, resulting in bogus values (I haven't thought through this hard enough to explain why the resulting value was 0xffff... - sign extension, possible UB, but in any case it's the wrong answer - in this particular case I was looking at that resulted in a size so large that we couldn't open a file large enough to write to and ended up with a rather vague: error: 'file_name.o': Invalid argument
This commit is contained in:
parent
4f7d0be5fe
commit
d3ee11b29a
@ -1786,7 +1786,7 @@ template <class ELFT> Error ELFBuilder<ELFT>::readSectionHeaders() {
|
||||
Sec->OriginalIndex = Sec->Index;
|
||||
Sec->OriginalData =
|
||||
ArrayRef<uint8_t>(ElfFile.base() + Shdr.sh_offset,
|
||||
(Shdr.sh_type == SHT_NOBITS) ? 0 : Shdr.sh_size);
|
||||
(Shdr.sh_type == SHT_NOBITS) ? (size_t)0 : Shdr.sh_size);
|
||||
}
|
||||
|
||||
return Error::success();
|
||||
|
Loading…
Reference in New Issue
Block a user