From d5d2d4a1584522694d6204c5b036521faf37c981 Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Fri, 11 Mar 2011 00:48:56 +0000 Subject: [PATCH] Avoid replacing the value of a directly stored load with the stored value if the load is indexed. rdar://9117613. llvm-svn: 127440 --- lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 3 +- .../CodeGen/ARM/2011-03-10-DAGCombineCrash.ll | 47 +++++++++++++++++++ 2 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 test/CodeGen/ARM/2011-03-10-DAGCombineCrash.ll diff --git a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 4c70bc3e88b..f9f89858c97 100644 --- a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -5862,8 +5862,7 @@ SDValue DAGCombiner::visitLOAD(SDNode *N) { // value. // TODO: Handle store large -> read small portion. // TODO: Handle TRUNCSTORE/LOADEXT - if (LD->getExtensionType() == ISD::NON_EXTLOAD && - !LD->isVolatile()) { + if (ISD::isNormalLoad(N) && !LD->isVolatile()) { if (ISD::isNON_TRUNCStore(Chain.getNode())) { StoreSDNode *PrevST = cast(Chain); if (PrevST->getBasePtr() == Ptr && diff --git a/test/CodeGen/ARM/2011-03-10-DAGCombineCrash.ll b/test/CodeGen/ARM/2011-03-10-DAGCombineCrash.ll new file mode 100644 index 00000000000..81babe0b4b1 --- /dev/null +++ b/test/CodeGen/ARM/2011-03-10-DAGCombineCrash.ll @@ -0,0 +1,47 @@ +; RUN: llc < %s -mtriple=thumbv7-apple-darwin10 -relocation-model=pic -disable-fp-elim -mcpu=cortex-a8 + +; rdar://9117613 + +%struct.mo = type { i32, %struct.mo_pops* } +%struct.mo_pops = type { void (%struct.mo*)*, void (%struct.mo*)*, i32 (%struct.mo*, i32*, i32)*, i32 (%struct.mo*)*, i32 (%struct.mo*, i64, i32, i32, i32*, i64, i32)*, i32 (%struct.mo*, i64, i32, i64*, i32*, i32, i32, i32)*, i32 (%struct.mo*, i64, i32)*, i32 (%struct.mo*, i64, i64, i32)*, i32 (%struct.mo*, i64, i64, i32)*, i32 (%struct.mo*, i32)*, i32 (%struct.mo*)*, i32 (%struct.mo*, i32)*, i8* } +%struct.ui = type { %struct.mo*, i32*, i32, i32*, i32*, i64, i32*, i32*, i32* } + + +define internal fastcc i32 @t(i32* %vp, i32 %withfsize, i64 %filesize) nounwind { +entry: + br i1 undef, label %bb1, label %bb + +bb: ; preds = %entry + unreachable + +bb1: ; preds = %entry + %0 = call %struct.ui* @vn_pp_to_ui(i32* undef) nounwind + call void @llvm.memset.p0i8.i32(i8* undef, i8 0, i32 40, i32 4, i1 false) + %1 = getelementptr inbounds %struct.ui* %0, i32 0, i32 0 + store %struct.mo* undef, %struct.mo** %1, align 4 + %2 = getelementptr inbounds %struct.ui* %0, i32 0, i32 5 + %3 = load i64* %2, align 4 + %4 = call i32 @mo_create_nnm(%struct.mo* undef, i64 %3, i32** undef) nounwind + br i1 undef, label %bb3, label %bb2 + +bb2: ; preds = %bb1 + unreachable + +bb3: ; preds = %bb1 + br i1 undef, label %bb4, label %bb6 + +bb4: ; preds = %bb3 + %5 = call i32 @vn_size(i32* %vp, i64* %2, i32* undef) nounwind + unreachable + +bb6: ; preds = %bb3 + ret i32 0 +} + +declare %struct.ui* @vn_pp_to_ui(i32*) + +declare void @llvm.memset.p0i8.i32(i8* nocapture, i8, i32, i32, i1) nounwind + +declare i32 @mo_create_nnm(%struct.mo*, i64, i32**) + +declare i32 @vn_size(i32*, i64*, i32*)