From d6ec2efde8eb0eefb4b69b1220c5db550660b09a Mon Sep 17 00:00:00 2001 From: George Rimar Date: Tue, 5 Mar 2019 11:32:14 +0000 Subject: [PATCH] [llvm-objcopy] - Report "no zlib available" error properly when --compress-debug-sections is used. If zlib is not available, and --compress-debug-sections is passed, we want to report an error. Currently, it is only reported for --compress_debug_sections= form of the option. Fixes the https://bugs.llvm.org/show_bug.cgi?id=40886. I do not think there is a way to write a test for this. Differential revision: https://reviews.llvm.org/D58909 llvm-svn: 355391 --- tools/llvm-objcopy/CopyConfig.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/llvm-objcopy/CopyConfig.cpp b/tools/llvm-objcopy/CopyConfig.cpp index 3972a56a06b..fb362b7f5c9 100644 --- a/tools/llvm-objcopy/CopyConfig.cpp +++ b/tools/llvm-objcopy/CopyConfig.cpp @@ -476,11 +476,11 @@ Expected parseObjcopyOptions(ArrayRef ArgsArr) { InputArgs.getLastArgValue(OBJCOPY_compress_debug_sections_eq) .str() .c_str()); - if (!zlib::isAvailable()) - return createStringError( - errc::invalid_argument, - "LLVM was not compiled with LLVM_ENABLE_ZLIB: can not compress"); } + if (!zlib::isAvailable()) + return createStringError( + errc::invalid_argument, + "LLVM was not compiled with LLVM_ENABLE_ZLIB: can not compress"); } Config.AddGnuDebugLink = InputArgs.getLastArgValue(OBJCOPY_add_gnu_debuglink);