diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 531a0a15341..d3457ed841f 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -27307,8 +27307,9 @@ static SDValue combineIntegerAbs(SDNode *N, SelectionDAG &DAG) { /// into: /// SETGT(X, -1) static SDValue foldXorTruncShiftIntoCmp(SDNode *N, SelectionDAG &DAG) { - // This is only worth doing if the output type is i8. - if (N->getValueType(0) != MVT::i8) + // This is only worth doing if the output type is i8 or i1. + EVT ResultType = N->getValueType(0); + if (ResultType != MVT::i8 && ResultType != MVT::i1) return SDValue(); SDValue N0 = N->getOperand(0); @@ -27343,8 +27344,13 @@ static SDValue foldXorTruncShiftIntoCmp(SDNode *N, SelectionDAG &DAG) { SDLoc DL(N); SDValue ShiftOp = Shift.getOperand(0); EVT ShiftOpTy = ShiftOp.getValueType(); - SDValue Cond = DAG.getSetCC(DL, MVT::i8, ShiftOp, + const TargetLowering &TLI = DAG.getTargetLoweringInfo(); + EVT SetCCResultType = TLI.getSetCCResultType(DAG.getDataLayout(), + *DAG.getContext(), ResultType); + SDValue Cond = DAG.getSetCC(DL, SetCCResultType, ShiftOp, DAG.getConstant(-1, DL, ShiftOpTy), ISD::SETGT); + if (SetCCResultType != ResultType) + Cond = DAG.getNode(ISD::ZERO_EXTEND, DL, ResultType, Cond); return Cond; } diff --git a/test/CodeGen/X86/setcc.ll b/test/CodeGen/X86/setcc.ll index b4847c54ffa..d5874344fd1 100644 --- a/test/CodeGen/X86/setcc.ll +++ b/test/CodeGen/X86/setcc.ll @@ -54,3 +54,27 @@ entry: %add = shl nuw nsw i32 %conv4.2, 16 ret i32 %add } + +define i8 @t5(i32 %a) #0 { +entry: +; CHECK-LABEL: t5: +; CHECK: testl %edi, %edi +; CHECK: setns %al + %.lobit = lshr i32 %a, 31 + %trunc = trunc i32 %.lobit to i8 + %.not = xor i8 %trunc, 1 + ret i8 %.not +} + +define zeroext i1 @t6(i32 %a) #0 { +entry: +; CHECK-LABEL: t6: +; CHECK: testl %edi, %edi +; CHECK: setns %al + %.lobit = lshr i32 %a, 31 + %trunc = trunc i32 %.lobit to i1 + %.not = xor i1 %trunc, 1 + ret i1 %.not +} + +attributes #0 = { "target-cpu"="skylake-avx512" }