From db4b62f32e60c2e350106eae24e639205d74e035 Mon Sep 17 00:00:00 2001 From: Jakob Stoklund Olesen Date: Fri, 17 Dec 2010 23:16:35 +0000 Subject: [PATCH] Make the -verify-regalloc command line option available to base classes as RegAllocBase::VerifyEnabled. Run the machine code verifier in a few interesting places during RegAllocGreedy. llvm-svn: 122107 --- lib/CodeGen/RegAllocBase.h | 4 ++++ lib/CodeGen/RegAllocBasic.cpp | 9 +++++---- lib/CodeGen/RegAllocGreedy.cpp | 6 ++++++ 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/lib/CodeGen/RegAllocBase.h b/lib/CodeGen/RegAllocBase.h index 438a7d17bae..193c14460cc 100644 --- a/lib/CodeGen/RegAllocBase.h +++ b/lib/CodeGen/RegAllocBase.h @@ -156,6 +156,10 @@ protected: // Use this group name for NamedRegionTimer. static const char *TimerGroupName; +public: + /// VerifyEnabled - True when -verify-regalloc is given. + static bool VerifyEnabled; + private: void seedLiveVirtRegs(std::priority_queue >&); diff --git a/lib/CodeGen/RegAllocBasic.cpp b/lib/CodeGen/RegAllocBasic.cpp index f01ebf5030e..85a3d7f1202 100644 --- a/lib/CodeGen/RegAllocBasic.cpp +++ b/lib/CodeGen/RegAllocBasic.cpp @@ -53,11 +53,12 @@ static RegisterRegAlloc basicRegAlloc("basic", "basic register allocator", // Temporary verification option until we can put verification inside // MachineVerifier. -static cl::opt -VerifyRegAlloc("verify-regalloc", - cl::desc("Verify live intervals before renaming")); +static cl::opt +VerifyRegAlloc("verify-regalloc", cl::location(RegAllocBase::VerifyEnabled), + cl::desc("Verify during register allocation")); const char *RegAllocBase::TimerGroupName = "Register Allocation"; +bool RegAllocBase::VerifyEnabled = false; namespace { /// RABasic provides a minimal implementation of the basic register allocation @@ -475,7 +476,7 @@ bool RABasic::runOnMachineFunction(MachineFunction &mf) { // make the rewriter a separate pass and override verifyAnalysis instead. When // that happens, verification naturally falls under VerifyMachineCode. #ifndef NDEBUG - if (VerifyRegAlloc) { + if (VerifyEnabled) { // Verify accuracy of LiveIntervals. The standard machine code verifier // ensures that each LiveIntervals covers all uses of the virtual reg. diff --git a/lib/CodeGen/RegAllocGreedy.cpp b/lib/CodeGen/RegAllocGreedy.cpp index d8c1b3d4da5..8dbb56809bf 100644 --- a/lib/CodeGen/RegAllocGreedy.cpp +++ b/lib/CodeGen/RegAllocGreedy.cpp @@ -328,6 +328,9 @@ unsigned RAGreedy::trySplit(LiveInterval &VirtReg, AllocationOrder &Order, SplitEditor(*SA, *LIS, *VRM, *DomTree, LREdit) .splitAroundLoop(Loop->getLoop()); + if (VerifyEnabled) + MF->verify(this); + // We have new split regs, don't assign anything. return 0; } @@ -400,6 +403,9 @@ bool RAGreedy::runOnMachineFunction(MachineFunction &mf) { << ((Value*)mf.getFunction())->getName() << '\n'); MF = &mf; + if (VerifyEnabled) + MF->verify(this); + RegAllocBase::init(getAnalysis(), getAnalysis()); DomTree = &getAnalysis(); ReservedRegs = TRI->getReservedRegs(*MF);