RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 02:33:06 +01:00
Code Issues Projects Releases Wiki Activity

Handle indirect calls in preallocated verification

Browse Source 
Summary: getCalledFunction() returns null for indirect function invocations.

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79203
This commit is contained in:
Arthur Eubanks 2020-04-30 13:48:43 -07:00
parent ab2e9f7ef4
commit de37daa3f5
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/IR/Verifier.cpp
View File

@ -4485,7 +4485,7 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
Assert(UseCall != nullptr,
"Uses of llvm.call.preallocated.setup must be calls");
const Function *Fn = UseCall->getCalledFunction();
if (Fn->getIntrinsicID() == Intrinsic::call_preallocated_arg) {
if (Fn && Fn->getIntrinsicID() == Intrinsic::call_preallocated_arg) {
auto *AllocArgIndex = dyn_cast<ConstantInt>(UseCall->getArgOperand(1));
Assert(AllocArgIndex != nullptr,
"llvm.call.preallocated.alloc arg index must be a constant");
@ -4500,8 +4500,8 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
"llvm.call.preallocated.setup");
FoundCall = true;
size_t NumPreallocatedArgs = 0;
for (auto &Arg : Fn->args()) {
if (Arg.hasAttribute(Attribute::Preallocated)) {
for (unsigned i = 0; i < UseCall->getNumArgOperands(); i++) {
if (UseCall->paramHasAttr(i, Attribute::Preallocated)) {
++NumPreallocatedArgs;
}
}

8
test/Verifier/preallocated-valid.ll
View File

@ -14,6 +14,14 @@ define void @preallocated() {
ret void
}
define void @preallocated_indirect(void (i32*)* %f) {
%cs = call token @llvm.call.preallocated.setup(i32 1)
%x = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32)
%y = bitcast i8* %x to i32*
call void %f(i32* preallocated(i32) %y) ["preallocated"(token %cs)]
ret void
}
define void @preallocated_setup_without_call() {
%cs = call token @llvm.call.preallocated.setup(i32 1)
%a0 = call i8* @llvm.call.preallocated.arg(token %cs, i32 0) preallocated(i32)