RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00
Code Issues Projects Releases Wiki Activity

fixed a few typos in comments

Browse Source 
llvm-svn: 211634
This commit is contained in:
Sanjay Patel 2014-06-24 21:11:51 +00:00
parent ad1b24c1a0
commit def1964051
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/CodeGen/CriticalAntiDepBreaker.cpp
View File

@ -146,8 +146,8 @@ static const SDep *CriticalPathStep(const SUnit *SU) {
void CriticalAntiDepBreaker::PrescanInstruction(MachineInstr *MI) { void CriticalAntiDepBreaker::PrescanInstruction(MachineInstr *MI) {
// It's not safe to change register allocation for source operands of // It's not safe to change register allocation for source operands of
// that have special allocation requirements. Also assume all registers // instructions that have special allocation requirements. Also assume all
// used in a call must not be changed (ABI). // registers used in a call must not be changed (ABI).
// FIXME: The issue with predicated instruction is more complex. We are being // FIXME: The issue with predicated instruction is more complex. We are being
// conservative here because the kill markers cannot be trusted after // conservative here because the kill markers cannot be trusted after
// if-conversion: // if-conversion:
@ -309,7 +309,7 @@ void CriticalAntiDepBreaker::ScanInstruction(MachineInstr *MI,
// the two-address instruction also defines NewReg, as may happen with // the two-address instruction also defines NewReg, as may happen with
// pre/postincrement loads. In this case, both the use and def operands are in // pre/postincrement loads. In this case, both the use and def operands are in
// RegRefs because the def is inserted by PrescanInstruction and not erased // RegRefs because the def is inserted by PrescanInstruction and not erased
// during ScanInstruction. So checking for an instructions with definitions of // during ScanInstruction. So checking for an instruction with definitions of
// both NewReg and AntiDepReg covers it. // both NewReg and AntiDepReg covers it.
bool bool
CriticalAntiDepBreaker::isNewRegClobberedByRefs(RegRefIter RegRefBegin, CriticalAntiDepBreaker::isNewRegClobberedByRefs(RegRefIter RegRefBegin,
@ -325,7 +325,7 @@ CriticalAntiDepBreaker::isNewRegClobberedByRefs(RegRefIter RegRefBegin,
if (RefOper->isDef() && RefOper->isEarlyClobber()) if (RefOper->isDef() && RefOper->isEarlyClobber())
return true; return true;
// Handle cases in which this instructions defines NewReg. // Handle cases in which this instruction defines NewReg.
MachineInstr *MI = RefOper->getParent(); MachineInstr *MI = RefOper->getParent();
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) { for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
const MachineOperand &CheckOper = MI->getOperand(i); const MachineOperand &CheckOper = MI->getOperand(i);
@ -343,11 +343,11 @@ CriticalAntiDepBreaker::isNewRegClobberedByRefs(RegRefIter RegRefBegin,
return true; return true;
// Don't allow an instruction using AntiDepReg to be earlyclobbered by // Don't allow an instruction using AntiDepReg to be earlyclobbered by
// NewReg // NewReg.
if (CheckOper.isEarlyClobber()) if (CheckOper.isEarlyClobber())
return true; return true;
// Don't allow inline asm to define NewReg at all. Who know what it's // Don't allow inline asm to define NewReg at all. Who knows what it's
// doing with it. // doing with it.
if (MI->isInlineAsm()) if (MI->isInlineAsm())
return true; return true;
@ -494,8 +494,7 @@ BreakAntiDependencies(const std::vector<SUnit>& SUnits,
// as we go to help determine which registers are available. // as we go to help determine which registers are available.
unsigned Broken = 0; unsigned Broken = 0;
unsigned Count = InsertPosIndex - 1; unsigned Count = InsertPosIndex - 1;
for (MachineBasicBlock::iterator I = End, E = Begin; for (MachineBasicBlock::iterator I = End, E = Begin; I != E; --Count) {
I != E; --Count) {
MachineInstr *MI = --I; MachineInstr *MI = --I;
if (MI->isDebugValue()) if (MI->isDebugValue())
continue; continue;
@ -526,7 +525,7 @@ BreakAntiDependencies(const std::vector<SUnit>& SUnits,
// Don't break anti-dependencies on non-allocatable registers. // Don't break anti-dependencies on non-allocatable registers.
AntiDepReg = 0; AntiDepReg = 0;
else if (KeepRegs.test(AntiDepReg)) else if (KeepRegs.test(AntiDepReg))
// Don't break anti-dependencies if an use down below requires // Don't break anti-dependencies if a use down below requires
// this exact register. // this exact register.
AntiDepReg = 0; AntiDepReg = 0;
else { else {
@ -564,8 +563,7 @@ BreakAntiDependencies(const std::vector<SUnit>& SUnits,
// If MI's defs have a special allocation requirement, don't allow // If MI's defs have a special allocation requirement, don't allow
// any def registers to be changed. Also assume all registers // any def registers to be changed. Also assume all registers
// defined in a call must not be changed (ABI). // defined in a call must not be changed (ABI).
if (MI->isCall() || MI->hasExtraDefRegAllocReq() || if (MI->isCall() || MI->hasExtraDefRegAllocReq() || TII->isPredicated(MI))
TII->isPredicated(MI))
// If this instruction's defs have special allocation requirement, don't // If this instruction's defs have special allocation requirement, don't
// break this anti-dependency. // break this anti-dependency.
AntiDepReg = 0; AntiDepReg = 0;

6
lib/CodeGen/CriticalAntiDepBreaker.h
View File

@ -55,12 +55,12 @@ class TargetRegisterInfo;
typedef std::multimap<unsigned, MachineOperand *>::const_iterator typedef std::multimap<unsigned, MachineOperand *>::const_iterator
RegRefIter; RegRefIter;
/// KillIndices - The index of the most recent kill (proceding bottom-up), /// KillIndices - The index of the most recent kill (proceeding bottom-up),
/// or ~0u if the register is not live. /// or ~0u if the register is not live.
std::vector<unsigned> KillIndices; std::vector<unsigned> KillIndices;
/// DefIndices - The index of the most recent complete def (proceding bottom /// DefIndices - The index of the most recent complete def (proceeding
/// up), or ~0u if the register is live. /// bottom up), or ~0u if the register is live.
std::vector<unsigned> DefIndices; std::vector<unsigned> DefIndices;
/// KeepRegs - A set of registers which are live and cannot be changed to /// KeepRegs - A set of registers which are live and cannot be changed to