RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 11:02:59 +02:00
Code Issues Projects Releases Wiki Activity

Fix several bugs in named sections handling

Browse Source 
llvm-svn: 53312
This commit is contained in:
Anton Korobeynikov 2008-07-09 13:25:46 +00:00
parent 933bf0ecc4
commit df663a8ddf
2 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Target/TargetAsmInfo.cpp
View File

@ -235,7 +235,7 @@ TargetAsmInfo::SectionFlagsForGlobal(const GlobalValue *GV,
}
// Add flags from sections, if any.
if (Name) {
if (Name && *Name) {
Flags |= SectionFlags::Named;
// Some lame default implementation based on some magic section names.
@ -279,7 +279,7 @@ TargetAsmInfo::SectionForGlobal(const GlobalValue *GV) const {
// directive and also append funky flags. Otherwise - section name is just
// some magic assembler directive.
if (Flags & SectionFlags::Named)
Name = SwitchToSectionDirective + Name + PrintSectionFlags(Flags);
Name = getSwitchToSectionDirective() + Name + PrintSectionFlags(Flags);
return Name;
}

20
lib/Target/X86/X86TargetAsmInfo.cpp
View File

@ -336,9 +336,9 @@ X86ELFTargetAsmInfo::X86ELFTargetAsmInfo(const X86TargetMachine &TM):
bool is64Bit = X86TM->getSubtarget<X86Subtarget>().is64Bit();
ReadOnlySection = ".rodata";
FourByteConstantSection = ".rodata.cst";
EightByteConstantSection = ".rodata.cst";
SixteenByteConstantSection = ".rodata.cst";
FourByteConstantSection = "\t.section\t.rodata.cst4,\"aM\",@progbits,4";
EightByteConstantSection = "\t.section\t.rodata.cst8,\"aM\",@progbits,8";
SixteenByteConstantSection = "\t.section\t.rodata.cst16,\"aM\",@progbits,16";
CStringSection = ".rodata.str";
PrivateGlobalPrefix = ".L";
WeakRefDirective = "\t.weak\t";
@ -466,12 +466,10 @@ X86ELFTargetAsmInfo::MergeableConstSection(const GlobalVariable *GV) const {
unsigned Size = SectionFlags::getEntitySize(Flags);
// FIXME: string here is temporary, until stuff will fully land in.
if (Size == 4)
return FourByteConstantSection;
else if (Size == 8)
return EightByteConstantSection;
else if (Size == 16)
return SixteenByteConstantSection;
// We cannot use {Four,Eight,Sixteen}ByteConstantSection here, since it's
// currently directly used by asmprinter.
if (Size == 4 || Size == 8 || Size == 16)
return ".rodata.cst" + utostr(Size);
return getReadOnlySection();
}
@ -525,8 +523,8 @@ X86ELFTargetAsmInfo::SectionFlagsForGlobal(const GlobalValue *GV,
// Mark section as named, when needed (so, we we will need .section directive
// to switch into it).
if (Flags & (SectionFlags::Mergeable ||
SectionFlags::TLS ||
if (Flags & (SectionFlags::Mergeable |
SectionFlags::TLS |
SectionFlags::Linkonce))
Flags |= SectionFlags::Named;