RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[InstCombine] Transform !range metadata to !nonnull when combining loads

Browse Source 
When combining an integer load with !range metadata that does not include 0 to a pointer load, make sure emit !nonnull metadata on the newly-created pointer load. This prevents the !nonnull metadata from being dropped during a ptrtoint/inttoptr pair.

This fixes PR30597.

Patch by Ariel Ben-Yehuda!

Differential Revision: https://reviews.llvm.org/D25215

llvm-svn: 283836
This commit is contained in:
David Majnemer 2016-10-11 01:00:45 +00:00
parent f515b3c80c
commit e00f20b94a
2 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
View File

@ -379,8 +379,16 @@ static LoadInst *combineLoadToNewType(InstCombiner &IC, LoadInst &LI, Type *NewT
break;
case LLVMContext::MD_range:
// FIXME: It would be nice to propagate this in some way, but the type
// conversions make it hard. If the new type is a pointer, we could
// translate it to !nonnull metadata.
// conversions make it hard.
// If it's a pointer now and the range does not contain 0, make it !nonnull.
if (NewTy->isPointerTy()) {
unsigned BitWidth = IC.getDataLayout().getTypeSizeInBits(NewTy);
if (!getConstantRangeFromMetadata(*N).contains(APInt(BitWidth, 0))) {
MDNode *NN = MDNode::get(LI.getContext(), None);
NewLoad->setMetadata(LLVMContext::MD_nonnull, NN);
}
}
break;
}
}

32
test/Transforms/InstCombine/PR30597.ll Normal file
View File

@ -0,0 +1,32 @@
; RUN: opt < %s -instcombine -S | FileCheck %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; Function Attrs: readonly uwtable
define i1 @dot_ref_s(i32** noalias nocapture readonly dereferenceable(8)) {
entry-block:
%loadedptr = load i32*, i32** %0, align 8, !nonnull !0
%ptrtoint = ptrtoint i32* %loadedptr to i64
%inttoptr = inttoptr i64 %ptrtoint to i32*
%switchtmp = icmp eq i32* %inttoptr, null
ret i1 %switchtmp
; CHECK-LABEL: @dot_ref_s
; CHECK-NEXT: entry-block:
; CHECK-NEXT: ret i1 false
}
; Function Attrs: readonly uwtable
define i64* @function(i64* noalias nocapture readonly dereferenceable(8)) {
entry-block:
%loaded = load i64, i64* %0, align 8, !range !1
%inttoptr = inttoptr i64 %loaded to i64*
ret i64* %inttoptr
; CHECK-LABEL: @function
; CHECK: %{{.+}} = load i64*, i64** %{{.+}}, align 8, !nonnull
}
!0 = !{}
!1 = !{i64 1, i64 140737488355327}