RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

Tighten up checking on SymbolTable interface to make it illegal to pass a

Browse Source 
Type* where a Value* is expected.

llvm-svn: 13794
This commit is contained in:
Reid Spencer 2004-05-26 21:46:18 +00:00
parent edff018f18
commit e4f0ec88eb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/llvm/SymbolTable.h
View File

@ -165,8 +165,9 @@ public:
/// @brief Insert a constant or type. /// @brief Insert a constant or type.
inline void insert(const std::string &Name, Value *Val) { inline void insert(const std::string &Name, Value *Val) {
assert(Val && "Can't insert null type into symbol table!"); assert(Val && "Can't insert null type into symbol table!");
assert((isa<Type>(Val) || isa<Constant>(Val)) && assert(!isa<Type>(Val) && "Cannot insert types with this interface!");
"Can only insert types and constants into a symbol table!"); assert(isa<Constant>(Val) &&
"Can only insert constants into a symbol table!");
insertEntry(Name, Val->getType(), Val); insertEntry(Name, Val->getType(), Val);
} }
@ -201,6 +202,7 @@ public:
/// @brief Remove a constant or type from the symbol table. /// @brief Remove a constant or type from the symbol table.
inline Value* remove(const std::string &Name, Value *Val) { inline Value* remove(const std::string &Name, Value *Val) {
assert(Val && "Can't remove null value from symbol table!"); assert(Val && "Can't remove null value from symbol table!");
assert(!isa<Type>(Val) && "Can't remove types with this interface!");
plane_iterator PI = pmap.find(Val->getType()); plane_iterator PI = pmap.find(Val->getType());
return removeEntry(PI, PI->second.find(Name)); return removeEntry(PI, PI->second.find(Name));
} }