RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 02:52:53 +02:00
Code Issues Projects Releases Wiki Activity

[LoopCacheAnalysis]: Fix assertion failure during cost computation

Browse Source 
Ensure the stride and trip count have the same type before multiplying them during reference cost calculation

Reviewed By: jdoefert

Differential Revision: https://reviews.llvm.org/D70192
This commit is contained in:
Rachel Craik 2019-11-15 14:56:26 -05:00
parent 2c6c0c32ff
commit e95e1acfea
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Analysis/LoopCacheAnalysis.cpp
View File

@ -284,6 +284,9 @@ CacheCostTy IndexedReference::computeRefCost(const Loop &L,
const SCEV *ElemSize = Sizes.back();
const SCEV *Stride = SE.getMulExpr(Coeff, ElemSize);
const SCEV *CacheLineSize = SE.getConstant(Stride->getType(), CLS);
Type *WiderType = SE.getWiderType(Stride->getType(), TripCount->getType());
Stride = SE.getNoopOrSignExtend(Stride, WiderType);
TripCount = SE.getNoopOrAnyExtend(TripCount, WiderType);
const SCEV *Numerator = SE.getMulExpr(Stride, TripCount);
RefCost = SE.getUDivExpr(Numerator, CacheLineSize);
LLVM_DEBUG(dbgs().indent(4)

35
test/Analysis/LoopCacheAnalysis/PowerPC/compute-cost.ll Normal file
View File

@ -0,0 +1,35 @@
; RUN: opt < %s -passes='print<loop-cache-cost>' -disable-output 2>&1 | FileCheck %s
target datalayout = "e-m:e-i64:64-n32:64"
target triple = "powerpc64le-unknown-linux-gnu"
; Check IndexedReference::computeRefCost can handle type differences between
; Stride and TripCount
; CHECK: Loop 'for.cond' has cost = 64
%struct._Handleitem = type { %struct._Handleitem* }
define void @handle_to_ptr(%struct._Handleitem** %blocks) {
; Preheader:
entry:
br label %for.cond
; Loop:
for.cond: ; preds = %for.body, %entry
%i.0 = phi i32 [ 1, %entry ], [ %inc, %for.body ]
%cmp = icmp ult i32 %i.0, 1024
br i1 %cmp, label %for.body, label %for.end
for.body: ; preds = %for.cond
%idxprom = zext i32 %i.0 to i64
%arrayidx = getelementptr inbounds %struct._Handleitem*, %struct._Handleitem** %blocks, i64 %idxprom
store %struct._Handleitem* null, %struct._Handleitem** %arrayidx, align 8
%inc = add nuw nsw i32 %i.0, 1
br label %for.cond
; Exit blocks
for.end: ; preds = %for.cond
ret void
}