Tighten up the AnalysisUsage of lots of passes, primarily to correctly indicate whether or not they invalidate the CFGA

llvm-svn: 2386

lib/Target/Sparc/EmitAssembly.cpp

@@ -209,6 +209,10 @@ struct SparcFunctionAsmPrinter : public FunctionPass, public AsmPrinter {
     return false;
   }
 
+  virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.setPreservesAll();
+  }
+
   void emitFunction(const Function *F);
 private :
   void emitBasicBlock(const BasicBlock *BB);
@@ -427,6 +431,11 @@ public:
     return false;
   }
 
+  virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.setPreservesAll();
+  }
+
+private:
   void emitGlobalsAndConstants(const Module *M);
 
   void printGlobalVariable(const GlobalVariable *GV);
@@ -436,7 +445,6 @@ public:
 
   static void FoldConstants(const Module *M,
                             std::hash_set<const Constant*> &moduleConstants);
-
 };
 
 

lib/Transforms/HoistPHIConstants.cpp

@@ -76,6 +76,10 @@ static bool doHoistPHIConstants(Function *M) {
 namespace {
   struct HoistPHIConstants : public FunctionPass {
     virtual bool runOnFunction(Function *F) { return doHoistPHIConstants(F); }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.preservesCFG();
+    }
   };
 }
 

lib/Transforms/IPO/ConstantMerge.cpp

@@ -82,6 +82,10 @@ namespace {
       Constants.clear();
       return false;
     }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.setPreservesAll();
+    }
   };
   
   struct DynamicConstantMerge : public ConstantMerge {

lib/Transforms/Instrumentation/TraceValues.cpp

@@ -49,6 +49,10 @@ namespace {
     bool runOnFunction(Function *F) {
       return doit(F, TraceBasicBlockExits, TraceFunctionExits, PrintfFunc);
     }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.preservesCFG();
+    }
   };
 } // end anonymous namespace
 

lib/Transforms/LevelRaise.cpp

@@ -472,6 +472,10 @@ static bool doRPR(Function *F) {
 namespace {
   struct RaisePointerReferences : public FunctionPass {
     virtual bool runOnFunction(Function *F) { return doRPR(F); }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.preservesCFG();
+    }
   };
 }
 

lib/Transforms/Scalar/ConstantProp.cpp

@@ -219,6 +219,12 @@ namespace {
       
       return Modified;
     }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      // FIXME: This pass does not preserve the CFG because it folds terminator
+      // instructions!
+      //AU.preservesCFG();
+    }
   };
 }
 

lib/Transforms/Scalar/DecomposeMultiDimRefs.cpp

@@ -175,6 +175,10 @@ namespace {
     virtual bool runOnFunction(Function *F) {
       return doDecomposeMultiDimRefs(F);
     }
+
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.preservesCFG();
+    }
   };
 }
 

lib/Transforms/Scalar/GCSE.cpp

@@ -51,7 +51,7 @@ namespace {
 
     // This transformation requires dominator and immediate dominator info
     virtual void getAnalysisUsage(AnalysisUsage &AU) const {
-      //preservesCFG(AU);
+      AU.preservesCFG();
       AU.addRequired(DominatorSet::ID);
       AU.addRequired(ImmediateDominators::ID); 
     }

lib/Transforms/Scalar/IndVarSimplify.cpp

@@ -203,6 +203,7 @@ namespace {
     
     virtual void getAnalysisUsage(AnalysisUsage &AU) const {
       AU.addRequired(LoopInfo::ID);
+      AU.preservesCFG();
     }
   };
 }

lib/Transforms/Scalar/InstructionCombining.cpp

@@ -42,10 +42,12 @@ namespace {
     }
 
   public:
-
-
     virtual bool runOnFunction(Function *F);
 
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.preservesCFG();
+    }
+
     // Visitation implementation - Implement instruction combining for different
     // instruction types.  The semantics are as follows:
     // Return Value:

lib/Transforms/Scalar/SCCP.cpp

@@ -470,6 +470,10 @@ namespace {
       SCCP S(F);
       return S.doSCCP();
     }
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      // FIXME: SCCP does not preserve the CFG because it folds terminators!
+      //AU.preservesCFG();
+    }
   };
 }
 

lib/Transforms/Scalar/SymbolStripping.cpp

@@ -64,6 +64,9 @@ namespace {
     virtual bool runOnFunction(Function *F) {
       return doSymbolStripping(F);
     }
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.setPreservesAll();
+    }
   };
 
   struct FullSymbolStripping : public SymbolStripping {

lib/Transforms/Utils/PromoteMemoryToRegister.cpp

@@ -53,6 +53,7 @@ namespace {
     //
     virtual void getAnalysisUsage(AnalysisUsage &AU) const {
       AU.addRequired(DominanceFrontier::ID);
+      AU.preservesCFG();
     }
 
   private:

lib/VMCore/Verifier.cpp

@@ -81,6 +81,10 @@ namespace {  // Anonymous namespace for class
       return false;
     }
 
+    virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+      AU.setPreservesAll();
+    }
+
     // Verification methods...
     void verifySymbolTable(SymbolTable *ST);
     void visitFunction(Function *F);

tools/analyze/analyze.cpp

@@ -110,6 +110,7 @@ public:
 
   virtual void getAnalysisUsage(AnalysisUsage &AU) const {
     AU.addRequired(ID);
+    AU.setPreservesAll();
   }
 };
 
@@ -137,6 +138,10 @@ struct InstForest : public FunctionPass {
   void doit(Function *F) {
     std::cout << analysis::InstForest<char>(F);
   }
+
+  virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.setPreservesAll();
+  }
 };
 
 struct IndVars : public FunctionPass {
@@ -152,6 +157,7 @@ struct IndVars : public FunctionPass {
 
   void getAnalysisUsage(AnalysisUsage &AU) const {
     AU.addRequired(LoopInfo::ID);
+    AU.setPreservesAll();
   }
 };
 
@@ -183,6 +189,9 @@ struct Exprs : public FunctionPass {
       std::cout << "\n\n";
     }
   }
+  virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.setPreservesAll();
+  }
 };