diff --git a/lib/Linker/IRMover.cpp b/lib/Linker/IRMover.cpp index b21b8f33ab4..7635092dd43 100644 --- a/lib/Linker/IRMover.cpp +++ b/lib/Linker/IRMover.cpp @@ -1223,7 +1223,9 @@ Error IRLinker::linkModuleFlagsMetadata() { if (SrcBehaviorValue == Module::Override && SrcOp->getOperand(2) != DstOp->getOperand(2)) return stringErr("linking module flags '" + ID->getString() + - "': IDs have conflicting override values"); + "': IDs have conflicting override values in '" + + SrcM->getModuleIdentifier() + "' and '" + + DstM.getModuleIdentifier() + "'"); continue; } else if (SrcBehaviorValue == Module::Override) { // Update the destination flag to that of the source. @@ -1234,7 +1236,9 @@ Error IRLinker::linkModuleFlagsMetadata() { // Diagnose inconsistent merge behavior types. if (SrcBehaviorValue != DstBehaviorValue) return stringErr("linking module flags '" + ID->getString() + - "': IDs have conflicting behaviors"); + "': IDs have conflicting behaviors in '" + + SrcM->getModuleIdentifier() + "' and '" + + DstM.getModuleIdentifier() + "'"); auto replaceDstValue = [&](MDNode *New) { Metadata *FlagOps[] = {DstOp->getOperand(0), ID, New}; @@ -1252,7 +1256,9 @@ Error IRLinker::linkModuleFlagsMetadata() { // Emit an error if the values differ. if (SrcOp->getOperand(2) != DstOp->getOperand(2)) return stringErr("linking module flags '" + ID->getString() + - "': IDs have conflicting values"); + "': IDs have conflicting values in '" + + SrcM->getModuleIdentifier() + "' and '" + + DstM.getModuleIdentifier() + "'"); continue; } case Module::Warning: { diff --git a/test/Linker/module-flags-5-a.ll b/test/Linker/module-flags-5-a.ll index 00fb4d15017..d7ebee08cd0 100644 --- a/test/Linker/module-flags-5-a.ll +++ b/test/Linker/module-flags-5-a.ll @@ -2,7 +2,7 @@ ; Test the 'override' error. -; CHECK: linking module flags 'foo': IDs have conflicting override values +; CHECK: linking module flags 'foo': IDs have conflicting override values in '{{.*}}module-flags-5-b.ll' and 'llvm-link' !0 = !{ i32 4, !"foo", i32 927 } diff --git a/test/Linker/module-flags-6-a.ll b/test/Linker/module-flags-6-a.ll index e15fd349eb5..dd6519727f2 100644 --- a/test/Linker/module-flags-6-a.ll +++ b/test/Linker/module-flags-6-a.ll @@ -2,7 +2,7 @@ ; Test module flags error messages. -; CHECK: linking module flags 'foo': IDs have conflicting values +; CHECK: linking module flags 'foo': IDs have conflicting values in '{{.*}}module-flags-6-b.ll' and 'llvm-link' !0 = !{ i32 1, !"foo", i32 37 } diff --git a/test/Linker/module-flags-7-a.ll b/test/Linker/module-flags-7-a.ll index 46c9d265ea3..b8732c73401 100644 --- a/test/Linker/module-flags-7-a.ll +++ b/test/Linker/module-flags-7-a.ll @@ -2,7 +2,7 @@ ; Test module flags error messages. -; CHECK: linking module flags 'foo': IDs have conflicting behaviors +; CHECK: linking module flags 'foo': IDs have conflicting behaviors in '{{.*}}module-flags-7-b.ll' and 'llvm-link' !0 = !{ i32 1, !"foo", i32 37 }