RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 19:52:54 +01:00
Code Issues Projects Releases Wiki Activity

Disable sibcall optimization for Thumb1 for now since Thumb1RegisterInfo::emitEpilogue is not expecting them.

Browse Source 
llvm-svn: 106368
This commit is contained in:
Evan Cheng 2010-06-19 01:01:32 +00:00
parent b6dfc01862
commit f40b8f0e32
4 changed files with 33 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Target/ARM/ARMISelLowering.cpp
View File

@ -1389,7 +1389,6 @@ ARMTargetLowering::IsEligibleForTailCallOptimization(SDValue Callee,
const SmallVectorImpl<ISD::OutputArg> &Outs, const SmallVectorImpl<ISD::OutputArg> &Outs,
const SmallVectorImpl<ISD::InputArg> &Ins, const SmallVectorImpl<ISD::InputArg> &Ins,
SelectionDAG& DAG) const { SelectionDAG& DAG) const {
const Function *CallerF = DAG.getMachineFunction().getFunction(); const Function *CallerF = DAG.getMachineFunction().getFunction();
CallingConv::ID CallerCC = CallerF->getCallingConv(); CallingConv::ID CallerCC = CallerF->getCallingConv();
bool CCMatch = CallerCC == CalleeCC; bool CCMatch = CallerCC == CalleeCC;
@ -1407,19 +1406,29 @@ ARMTargetLowering::IsEligibleForTailCallOptimization(SDValue Callee,
if (isCalleeStructRet || isCallerStructRet) if (isCalleeStructRet || isCallerStructRet)
return false; return false;
// FIXME: Completely disable sibcal for Thumb1 since Thumb1RegisterInfo::
// emitEpilogue is not ready for them.
if (Subtarget->isThumb1Only())
return false;
if (isa<ExternalSymbolSDNode>(Callee))
return false;
if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) {
if (Subtarget->isThumb1Only())
return false;
// On Thumb, for the moment, we can only do this to functions defined in this // On Thumb, for the moment, we can only do this to functions defined in this
// compilation, or to indirect calls. A Thumb B to an ARM function is not // compilation, or to indirect calls. A Thumb B to an ARM function is not
// easily fixed up in the linker, unlike BL. // easily fixed up in the linker, unlike BL.
if (Subtarget->isThumb()) { if (Subtarget->isThumb()) {
if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) {
const GlobalValue *GV = G->getGlobal(); const GlobalValue *GV = G->getGlobal();
if (GV->isDeclaration() || GV->isWeakForLinker()) if (GV->isDeclaration() || GV->isWeakForLinker())
return false; return false;
} else if (isa<ExternalSymbolSDNode>(Callee)) {
return false;
} }
} }
// If the calling conventions do not match, then we'd better make sure the // If the calling conventions do not match, then we'd better make sure the
// results are returned in the same way as what the caller expects. // results are returned in the same way as what the caller expects.
if (!CCMatch) { if (!CCMatch) {

11
test/CodeGen/ARM/call-tc.ll
View File

@ -7,22 +7,25 @@
declare void @g(i32, i32, i32, i32) declare void @g(i32, i32, i32, i32)
define void @f() { define void @t1() {
; CHECKELF: t1:
; CHECKELF: PLT ; CHECKELF: PLT
call void @g( i32 1, i32 2, i32 3, i32 4 ) call void @g( i32 1, i32 2, i32 3, i32 4 )
ret void ret void
} }
define void @g.upgrd.1() { define void @t2() {
; CHECKV4: t2:
; CHECKV4: bx r0 @ TAILCALL ; CHECKV4: bx r0 @ TAILCALL
; CHECKV5: t2:
; CHECKV5: bx r0 @ TAILCALL ; CHECKV5: bx r0 @ TAILCALL
%tmp = load i32 ()** @t ; <i32 ()*> [#uses=1] %tmp = load i32 ()** @t ; <i32 ()*> [#uses=1]
%tmp.upgrd.2 = tail call i32 %tmp( ) ; <i32> [#uses=0] %tmp.upgrd.2 = tail call i32 %tmp( ) ; <i32> [#uses=0]
ret void ret void
} }
define i32* @m_231b(i32, i32, i32*, i32*, i32*) nounwind { define i32* @t3(i32, i32, i32*, i32*, i32*) nounwind {
; CHECKV4: m_231b ; CHECKV4: t3:
; CHECKV4: bx r{{.*}} ; CHECKV4: bx r{{.*}}
BB0: BB0:
%5 = inttoptr i32 %0 to i32* ; <i32*> [#uses=1] %5 = inttoptr i32 %0 to i32* ; <i32*> [#uses=1]

8
test/CodeGen/Thumb/2010-06-18-SibCallCrash.ll Normal file
View File

@ -0,0 +1,8 @@
; RUN: llc -march=thumb < %s
; rdar://8104457
define arm_apcscc void @t(i32* %m) nounwind {
entry:
tail call arm_apcscc void undef(i32* %m, i16 zeroext undef) nounwind
ret void
}

2
test/CodeGen/Thumb2/thumb2-call-tc.ll
View File

@ -11,7 +11,7 @@ define void @f() {
; LINUX: f: ; LINUX: f:
; LINUX: bl g ; LINUX: bl g
call void @g( i32 1, i32 2, i32 3, i32 4 ) tail call void @g( i32 1, i32 2, i32 3, i32 4 )
ret void ret void
} }