1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00

[MachineOutliner] Check for explicit uses of LR/W30 in MI operands

Before, the outliner would grab ADRPs that used LR/W30. This patch fixes
that by checking for explicit uses of those registers before the special-casing
for ADRPs.

This also adds a test that ensures that those sorts of ADRPs won't be outlined.

llvm-svn: 330783
This commit is contained in:
Jessica Paquette 2018-04-24 22:38:15 +00:00
parent 8532085a99
commit f7f9e664cd
2 changed files with 62 additions and 0 deletions

View File

@ -5061,6 +5061,11 @@ AArch64InstrInfo::getOutliningType(MachineBasicBlock::iterator &MIT,
if (MOP.isCPI() || MOP.isJTI() || MOP.isCFIIndex() || MOP.isFI() ||
MOP.isTargetIndex())
return MachineOutlinerInstrType::Illegal;
// If it uses LR or W30 explicitly, then don't touch it.
if (MOP.isReg() && !MOP.isImplicit() &&
(MOP.getReg() == AArch64::LR || MOP.getReg() == AArch64::W30))
return MachineOutlinerInstrType::Illegal;
}
// Special cases for instructions that can always be outlined, but will fail

View File

@ -0,0 +1,57 @@
# RUN: llc -simplify-mir -run-pass=machine-outliner -verify-machineinstrs %s -o - | FileCheck %s
# CHECK-NOT: OUTLINED_FUNCTION
--- |
target triple = "arm64----"
@g = external global i64, align 8
define void @foo() #0 {
ret void
}
define void @foo2() #0 {
ret void
}
define void @foo3() #0 {
ret void
}
attributes #0 = { nounwind noredzone }
...
---
name: foo
alignment: 2
tracksRegLiveness: true
body: |
bb.0 (%ir-block.0):
liveins: $x27, $lr
$x27 = ADRP target-flags(aarch64-page, aarch64-got) @g
$lr = ADRP target-flags(aarch64-page, aarch64-got) @g
RET undef $lr
...
---
name: foo2
alignment: 2
tracksRegLiveness: true
body: |
bb.0 (%ir-block.0):
liveins: $x27, $lr
$x27 = ADRP target-flags(aarch64-page, aarch64-got) @g
$lr = ADRP target-flags(aarch64-page, aarch64-got) @g
RET undef $lr
...
---
name: foo3
alignment: 2
tracksRegLiveness: true
body: |
bb.0 (%ir-block.0):
liveins: $x27, $lr
$x27 = ADRP target-flags(aarch64-page, aarch64-got) @g
$lr = ADRP target-flags(aarch64-page, aarch64-got) @g
RET undef $lr
...