From f984a8d893f14d18023b2d4135969248ab48f62e Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Wed, 8 Jan 2020 09:48:01 +0800 Subject: [PATCH] [docs] Improve HowTo commit changes from git Summary: As a novice here I tried to `git push` my changes for a while before figuring out the correct workflow which is described on other pages. This small change doesn't reduce redundancy between those pages, but at least readers can follow the links now. Reviewers: Kokan, Jim Reviewed By: Kokan, Jim Subscribers: riccibruno, kiszk, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D72077 --- docs/GettingStarted.rst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/GettingStarted.rst b/docs/GettingStarted.rst index 086ae80d4b1..6dfca656d43 100644 --- a/docs/GettingStarted.rst +++ b/docs/GettingStarted.rst @@ -491,7 +491,11 @@ For developers to commit changes from Git ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Once a patch is reviewed, you should rebase it, re-test locally, and commit the -changes to LLVM's master branch. This is done using `git push`. +changes to LLVM's master branch. This is done using `git push` if you have the +required access rights. See `committing a change +`_ for Phabricator based commits or +`Developer Policy `_ for commit +access. LLVM currently has a linear-history policy, which means that merge commits are not allowed. The `llvm-project` repo on github is configured to reject pushes