RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

[llvm-tblgen] - Stop using std::string in RecordKeeper.

Browse Source 
RecordKeeper::getDef() is a hot place, it shows up in profiling
and it creates std::string instance for each search in RecordMap
though RecordKeeper::RecordMap can use StringRef as a key
instead to avoid that. Patch do that change.

Differential revision: https://reviews.llvm.org/D40170

llvm-svn: 318822
This commit is contained in:
George Rimar 2017-11-22 07:53:48 +00:00
parent 36a95a03e9
commit fb625e0c38
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/TableGen/Record.h
View File

@ -1525,7 +1525,7 @@ struct MultiClass {
};
class RecordKeeper {
using RecordMap = std::map<std::string, std::unique_ptr<Record>>;
using RecordMap = std::map<StringRef, std::unique_ptr<Record>>;
RecordMap Classes, Defs;
public:

9
utils/TableGen/CTagsEmitter.cpp
View File

@ -28,18 +28,17 @@ namespace {
class Tag {
private:
const std::string *Id;
StringRef Id;
SMLoc Loc;
public:
Tag(const std::string &Name, const SMLoc Location)
: Id(&Name), Loc(Location) {}
int operator<(const Tag &B) const { return *Id < *B.Id; }
Tag(StringRef Name, const SMLoc Location) : Id(Name), Loc(Location) {}
int operator<(const Tag &B) const { return Id < B.Id; }
void emit(raw_ostream &OS) const {
const MemoryBuffer *CurMB =
SrcMgr.getMemoryBuffer(SrcMgr.FindBufferContainingLoc(Loc));
auto BufferName = CurMB->getBufferIdentifier();
std::pair<unsigned, unsigned> LineAndColumn = SrcMgr.getLineAndColumn(Loc);
OS << *Id << "\t" << BufferName << "\t" << LineAndColumn.first << "\n";
OS << Id << "\t" << BufferName << "\t" << LineAndColumn.first << "\n";
}
};