diff --git a/lib/Target/RISCV/RISCVISelLowering.h b/lib/Target/RISCV/RISCVISelLowering.h index 4c9fd26e5cf..fc6968202f4 100644 --- a/lib/Target/RISCV/RISCVISelLowering.h +++ b/lib/Target/RISCV/RISCVISelLowering.h @@ -106,6 +106,10 @@ public: Instruction *emitTrailingFence(IRBuilder<> &Builder, Instruction *Inst, AtomicOrdering Ord) const override; + ISD::NodeType getExtendForAtomicOps() const override { + return ISD::SIGN_EXTEND; + } + private: void analyzeInputArgs(MachineFunction &MF, CCState &CCInfo, const SmallVectorImpl &Ins, diff --git a/test/CodeGen/RISCV/atomic-cmpxchg-flag.ll b/test/CodeGen/RISCV/atomic-cmpxchg-flag.ll new file mode 100644 index 00000000000..e5d619dc369 --- /dev/null +++ b/test/CodeGen/RISCV/atomic-cmpxchg-flag.ll @@ -0,0 +1,29 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv64 -mattr=+a -verify-machineinstrs < %s \ +; RUN: | FileCheck -check-prefix=RV64IA %s + +; This test ensures that the output of the 'lr.w' instruction is sign-extended. +; Previously, the default zero-extension was being used and 'cmp' parameter +; higher bits were masked to zero for the comparison. + +define i1 @cmpxchg_i32_seq_cst_seq_cst(i32* %ptr, i32 signext %cmp, + i32 signext %val) { +; RV64IA-LABEL: cmpxchg_i32_seq_cst_seq_cst: +; RV64IA: # %bb.0: # %entry +; RV64IA-NEXT: .LBB0_1: # %entry +; RV64IA-NEXT: # =>This Inner Loop Header: Depth=1 +; RV64IA-NEXT: lr.w.aqrl a3, (a0) +; RV64IA-NEXT: bne a3, a1, .LBB0_3 +; RV64IA-NEXT: # %bb.2: # %entry +; RV64IA-NEXT: # in Loop: Header=BB0_1 Depth=1 +; RV64IA-NEXT: sc.w.aqrl a4, a2, (a0) +; RV64IA-NEXT: bnez a4, .LBB0_1 +; RV64IA-NEXT: .LBB0_3: # %entry +; RV64IA-NEXT: xor a0, a3, a1 +; RV64IA-NEXT: seqz a0, a0 +; RV64IA-NEXT: ret +entry: + %0 = cmpxchg i32* %ptr, i32 %cmp, i32 %val seq_cst seq_cst + %1 = extractvalue { i32, i1 } %0, 1 + ret i1 %1 +}