From fbd4076941911605bf2755ad64c067410d998a80 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 11 Dec 2019 10:43:31 -0800 Subject: [PATCH] [StringRef] Test all default characters in unit test The default characters for trim, ltrim and rtrim are " \t\n\v\f\r" but only spaces were tested. Test that the others are trimmed as well. --- unittests/ADT/StringRefTest.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/unittests/ADT/StringRefTest.cpp b/unittests/ADT/StringRefTest.cpp index c37ecf36b63..2e5159dde1c 100644 --- a/unittests/ADT/StringRefTest.cpp +++ b/unittests/ADT/StringRefTest.cpp @@ -324,16 +324,20 @@ TEST(StringRefTest, Trim) { StringRef Str0("hello"); StringRef Str1(" hello "); StringRef Str2(" hello "); + StringRef Str3("\t\n\v\f\r hello \t\n\v\f\r"); EXPECT_EQ(StringRef("hello"), Str0.rtrim()); EXPECT_EQ(StringRef(" hello"), Str1.rtrim()); EXPECT_EQ(StringRef(" hello"), Str2.rtrim()); + EXPECT_EQ(StringRef("\t\n\v\f\r hello"), Str3.rtrim()); EXPECT_EQ(StringRef("hello"), Str0.ltrim()); EXPECT_EQ(StringRef("hello "), Str1.ltrim()); EXPECT_EQ(StringRef("hello "), Str2.ltrim()); + EXPECT_EQ(StringRef("hello \t\n\v\f\r"), Str3.ltrim()); EXPECT_EQ(StringRef("hello"), Str0.trim()); EXPECT_EQ(StringRef("hello"), Str1.trim()); EXPECT_EQ(StringRef("hello"), Str2.trim()); + EXPECT_EQ(StringRef("hello"), Str3.trim()); EXPECT_EQ(StringRef("ello"), Str0.trim("hhhhhhhhhhh"));