diff --git a/utils/NightlyTest.pl b/utils/NightlyTest.pl index db61914cddc..f2a8de0bc57 100755 --- a/utils/NightlyTest.pl +++ b/utils/NightlyTest.pl @@ -151,7 +151,21 @@ sub AddRecord { sub AddPreTag { # Add pre tags around nonempty list, or convert to "none" $_ = shift; - if (length) { return ""; } else { "none
"; } + if (length) { return "
$_
"; } else { "none
"; } +} + +sub ArrayToList { # Add
  • tags around nonempty list or convert to "none" + my $result = ""; + if (scalar @_) { + $result = ""; + } else { + $result = "

    none

    "; + } + return $result; } sub ChangeDir { # directory, logical name @@ -528,7 +542,7 @@ foreach $Warning (@Warn) { } } my $WarningsFile = join "\n", @Warnings; -my $WarningsList = AddPreTag $WarningsFile; +my $WarningsList = ArrayToList @Warnings; $WarningsFile =~ s/:[0-9]+:/::/g; # Emit the warnings file, so we can diff... @@ -539,8 +553,10 @@ my ($WarningsAdded, $WarningsRemoved) = DiffFiles "-Warnings.txt"; print "ADDED WARNINGS:\n$WarningsAdded\n\n" if (length $WarningsAdded); print "REMOVED WARNINGS:\n$WarningsRemoved\n\n" if (length $WarningsRemoved); -$WarningsAdded = AddPreTag $WarningsAdded; -$WarningsRemoved = AddPreTag $WarningsRemoved; +my @TmpWarningsAdded = split "\n", $WarningsAdded; +my @TmpWarningsRemoved = split "\n", $WarningsRemoved; +$WarningsAdded = ArrayToList @TmpWarningsAdded; +$WarningsRemoved = ArrayToList @TmpWarningsRemoved; # # Get some statistics about CVS commits over the current day... diff --git a/utils/NightlyTestTemplate.html b/utils/NightlyTestTemplate.html index 5312ebb4268..c38bb2e776b 100644 --- a/utils/NightlyTestTemplate.html +++ b/utils/NightlyTestTemplate.html @@ -77,7 +77,7 @@

    Warnings during the build:

    -

    $WarningsList

    +$WarningsList

    @@ -95,10 +95,10 @@

    Changes to Warnings:

    -
      -
    • Warnings Added: $WarningsAdded -
    • Warnings Removed: $WarningsRemoved -

    +

    Warnings Added:

    +$WarningsAdded +

    Warnings Removed:

    +$WarningsRemoved

    Changes in the test suite: