RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-26 12:43:36 +01:00
Code Issues Projects Releases Wiki Activity

[llvm-exegesis][NFC] Simplify BenchmarkRunner.

Browse Source 
Get rid of createExecutableFunction().

llvm-svn: 335240
This commit is contained in:
Clement Courbet 2018-06-21 14:49:04 +00:00
parent 70926d1510
commit fec24f4c46
1 changed files with 12 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
tools/llvm-exegesis/lib/BenchmarkRunner.cpp
View File

@ -91,25 +91,31 @@ BenchmarkRunner::runOne(const BenchmarkConfiguration &Configuration,
// that the inside instructions are repeated.
constexpr const int kMinInstructionsForSnippet = 16;
{
auto EF = createExecutableFunction(
auto ObjectFilePath = writeObjectFile(
GenerateInstructions(kMinInstructionsForSnippet));
if (llvm::Error E = EF.takeError()) {
if (llvm::Error E = ObjectFilePath.takeError()) {
InstrBenchmark.Error = llvm::toString(std::move(E));
return InstrBenchmark;
}
const auto FnBytes = EF->getFunctionBytes();
const ExecutableFunction EF(State.createTargetMachine(),
getObjectFromFile(*ObjectFilePath));
const auto FnBytes = EF.getFunctionBytes();
InstrBenchmark.AssembledSnippet.assign(FnBytes.begin(), FnBytes.end());
}
// Assemble NumRepetitions instructions repetitions of the snippet for
// measurements.
auto EF = createExecutableFunction(
auto ObjectFilePath = writeObjectFile(
GenerateInstructions(InstrBenchmark.NumRepetitions));
if (llvm::Error E = EF.takeError()) {
if (llvm::Error E = ObjectFilePath.takeError()) {
InstrBenchmark.Error = llvm::toString(std::move(E));
return InstrBenchmark;
}
InstrBenchmark.Measurements = runMeasurements(*EF, NumRepetitions);
llvm::outs() << "Check generated assembly with: /usr/bin/objdump -d "
<< *ObjectFilePath << "\n";
const ExecutableFunction EF(State.createTargetMachine(),
getObjectFromFile(*ObjectFilePath));
InstrBenchmark.Measurements = runMeasurements(EF, NumRepetitions);
return InstrBenchmark;
}
@ -137,22 +143,7 @@ BenchmarkRunner::writeObjectFile(llvm::ArrayRef<llvm::MCInst> Code) const {
return std::move(E);
llvm::raw_fd_ostream OFS(ResultFD, true /*ShouldClose*/);
assembleToStream(State.createTargetMachine(), Code, OFS);
llvm::outs() << "Check generated assembly with: /usr/bin/objdump -d "
<< ResultPath << "\n";
return ResultPath.str();
}
llvm::Expected<ExecutableFunction> BenchmarkRunner::createExecutableFunction(
llvm::ArrayRef<llvm::MCInst> Code) const {
auto ExpectedObjectPath = writeObjectFile(Code);
if (llvm::Error E = ExpectedObjectPath.takeError()) {
return std::move(E);
}
// FIXME: Check if TargetMachine or ExecutionEngine can be reused instead of
// creating one everytime.
return ExecutableFunction(State.createTargetMachine(),
getObjectFromFile(*ExpectedObjectPath));
}
} // namespace exegesis