mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
X86: Register the X86CallFrameOptimization pass
Summary: The motivation of this change is to enable .mir testing for this pass. Added one test case to cover the functionality, this same case will be improved by a future patch. Reviewers: igorb, guyblank, DavidKreitzer Reviewed By: guyblank, DavidKreitzer Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D38729 llvm-svn: 316412
This commit is contained in:
Zvi Rackover
parent
56df1ddeae
commit
ff00bdfe53
@ -56,14 +56,23 @@ static cl::opt<bool>
|
||||
cl::desc("Avoid optimizing x86 call frames for size"),
|
||||
cl::init(false), cl::Hidden);
|
||||
|
||||
namespace llvm {
|
||||
void initializeX86CallFrameOptimizationPass(PassRegistry &);
|
||||
}
|
||||
|
||||
namespace {
|
||||
|
||||
class X86CallFrameOptimization : public MachineFunctionPass {
|
||||
public:
|
||||
X86CallFrameOptimization() : MachineFunctionPass(ID) {}
|
||||
X86CallFrameOptimization() : MachineFunctionPass(ID) {
|
||||
initializeX86CallFrameOptimizationPass(
|
||||
*PassRegistry::getPassRegistry());
|
||||
}
|
||||
|
||||
bool runOnMachineFunction(MachineFunction &MF) override;
|
||||
|
||||
static char ID;
|
||||
|
||||
private:
|
||||
// Information we know about a particular call site
|
||||
struct CallContext {
|
||||
@ -120,12 +129,12 @@ private:
|
||||
MachineRegisterInfo *MRI;
|
||||
unsigned SlotSize;
|
||||
unsigned Log2SlotSize;
|
||||
static char ID;
|
||||
};
|
||||
|
||||
char X86CallFrameOptimization::ID = 0;
|
||||
|
||||
} // end anonymous namespace
|
||||
char X86CallFrameOptimization::ID = 0;
|
||||
INITIALIZE_PASS(X86CallFrameOptimization, DEBUG_TYPE,
|
||||
"X86 Call Frame Optimization", false, false)
|
||||
|
||||
// This checks whether the transformation is legal.
|
||||
// Also returns false in cases where it's potentially legal, but
|
||||
|
||||
@ -58,6 +58,7 @@ namespace llvm {
|
||||
|
||||
void initializeWinEHStatePassPass(PassRegistry &);
|
||||
void initializeFixupLEAPassPass(PassRegistry &);
|
||||
void initializeX86CallFrameOptimizationPass(PassRegistry &);
|
||||
void initializeX86CmovConverterPassPass(PassRegistry &);
|
||||
void initializeX86ExecutionDepsFixPass(PassRegistry &);
|
||||
void initializeX86DomainReassignmentPass(PassRegistry &);
|
||||
@ -75,6 +76,7 @@ extern "C" void LLVMInitializeX86Target() {
|
||||
initializeFixupBWInstPassPass(PR);
|
||||
initializeEvexToVexInstPassPass(PR);
|
||||
initializeFixupLEAPassPass(PR);
|
||||
initializeX86CallFrameOptimizationPass(PR);
|
||||
initializeX86CmovConverterPassPass(PR);
|
||||
initializeX86ExecutionDepsFixPass(PR);
|
||||
initializeX86DomainReassignmentPass(PR);
|
||||
|
||||
125
test/CodeGen/X86/movtopush.mir
Normal file
125
test/CodeGen/X86/movtopush.mir
Normal file
@ -0,0 +1,125 @@
|
||||
# RUN: llc -mtriple=i686-windows --run-pass="x86-cf-opt" %s -o - | FileCheck %s
|
||||
|
||||
--- |
|
||||
target datalayout = "e-m:x-p:32:32-i64:64-f80:32-n8:16:32-a:0:32-S32"
|
||||
target triple = "i686--windows-msvc"
|
||||
|
||||
%struct.s = type { i64 }
|
||||
|
||||
declare void @good(i32, i32, i32, i32)
|
||||
|
||||
declare void @struct(%struct.s* byval, i32, i32, i32)
|
||||
|
||||
; Function Attrs: optsize
|
||||
define void @test9() #0 {
|
||||
entry:
|
||||
%p = alloca i32, align 4
|
||||
%q = alloca i32, align 4
|
||||
%s = alloca %struct.s, align 4
|
||||
call void @good(i32 1, i32 2, i32 3, i32 4)
|
||||
%pv = ptrtoint i32* %p to i32
|
||||
%qv = ptrtoint i32* %q to i32
|
||||
call void @struct(%struct.s* byval %s, i32 6, i32 %qv, i32 %pv)
|
||||
ret void
|
||||
}
|
||||
|
||||
; Function Attrs: nounwind
|
||||
declare void @llvm.stackprotector(i8*, i8**) #1
|
||||
|
||||
attributes #0 = { optsize }
|
||||
attributes #1 = { nounwind }
|
||||
|
||||
...
|
||||
---
|
||||
# CHECK-LABEL: test9
|
||||
# CHECK: ADJCALLSTACKDOWN32 16, 0, 16, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
# CHECK-NEXT: PUSH32i8 4, implicit-def %esp, implicit %esp
|
||||
# CHECK-NEXT: PUSH32i8 3, implicit-def %esp, implicit %esp
|
||||
# CHECK-NEXT: PUSH32i8 2, implicit-def %esp, implicit %esp
|
||||
# CHECK-NEXT: PUSH32i8 1, implicit-def %esp, implicit %esp
|
||||
# CHECK-NEXT: CALLpcrel32 @good, csr_32, implicit %esp, implicit-def %esp
|
||||
# CHECK-NEXT: ADJCALLSTACKUP32 16, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
# CHECK-NEXT: ADJCALLSTACKDOWN32 20, 0, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
# CHECK-NEXT: %1 = MOV32rm %stack.2.s, 1, _, 0, _ :: (load 4 from %stack.2.s, align 8)
|
||||
# CHECK-NEXT: %2 = MOV32rm %stack.2.s, 1, _, 4, _ :: (load 4 from %stack.2.s + 4)
|
||||
# CHECK-NEXT: %3 = COPY %esp
|
||||
# CHECK-NEXT: MOV32mr %3, 1, _, 4, _, killed %2 :: (store 4)
|
||||
# CHECK-NEXT: MOV32mr %3, 1, _, 0, _, killed %1 :: (store 4)
|
||||
# CHECK-NEXT: %4 = LEA32r %stack.0.p, 1, _, 0, _
|
||||
# CHECK-NEXT: MOV32mr %3, 1, _, 16, _, killed %4 :: (store 4 into stack + 16)
|
||||
# CHECK-NEXT: %5 = LEA32r %stack.1.q, 1, _, 0, _
|
||||
# CHECK-NEXT: MOV32mr %3, 1, _, 12, _, killed %5 :: (store 4 into stack + 12)
|
||||
# CHECK-NEXT: MOV32mi %3, 1, _, 8, _, 6 :: (store 4 into stack + 8)
|
||||
# CHECK-NEXT: CALLpcrel32 @struct, csr_32, implicit %esp, implicit-def %esp
|
||||
# CHECK-NEXT: ADJCALLSTACKUP32 20, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
# CHECK-NEXT: RET 0
|
||||
name: test9
|
||||
alignment: 0
|
||||
exposesReturnsTwice: false
|
||||
legalized: false
|
||||
regBankSelected: false
|
||||
selected: false
|
||||
tracksRegLiveness: true
|
||||
registers:
|
||||
- { id: 0, class: gr32, preferred-register: '' }
|
||||
- { id: 1, class: gr32, preferred-register: '' }
|
||||
- { id: 2, class: gr32, preferred-register: '' }
|
||||
- { id: 3, class: gr32, preferred-register: '' }
|
||||
- { id: 4, class: gr32, preferred-register: '' }
|
||||
- { id: 5, class: gr32, preferred-register: '' }
|
||||
liveins:
|
||||
frameInfo:
|
||||
isFrameAddressTaken: false
|
||||
isReturnAddressTaken: false
|
||||
hasStackMap: false
|
||||
hasPatchPoint: false
|
||||
stackSize: 0
|
||||
offsetAdjustment: 0
|
||||
maxAlignment: 8
|
||||
adjustsStack: false
|
||||
hasCalls: true
|
||||
stackProtector: ''
|
||||
maxCallFrameSize: 4294967295
|
||||
hasOpaqueSPAdjustment: false
|
||||
hasVAStart: false
|
||||
hasMustTailInVarArgFunc: false
|
||||
savePoint: ''
|
||||
restorePoint: ''
|
||||
fixedStack:
|
||||
stack:
|
||||
- { id: 0, name: p, type: default, offset: 0, size: 4, alignment: 4,
|
||||
stack-id: 0, callee-saved-register: '', callee-saved-restored: true,
|
||||
di-variable: '', di-expression: '', di-location: '' }
|
||||
- { id: 1, name: q, type: default, offset: 0, size: 4, alignment: 4,
|
||||
stack-id: 0, callee-saved-register: '', callee-saved-restored: true,
|
||||
di-variable: '', di-expression: '', di-location: '' }
|
||||
- { id: 2, name: s, type: default, offset: 0, size: 8, alignment: 8,
|
||||
stack-id: 0, callee-saved-register: '', callee-saved-restored: true,
|
||||
di-variable: '', di-expression: '', di-location: '' }
|
||||
constants:
|
||||
body: |
|
||||
bb.0.entry:
|
||||
ADJCALLSTACKDOWN32 16, 0, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
%0 = COPY %esp
|
||||
MOV32mi %0, 1, _, 12, _, 4 :: (store 4 into stack + 12)
|
||||
MOV32mi %0, 1, _, 8, _, 3 :: (store 4 into stack + 8)
|
||||
MOV32mi %0, 1, _, 4, _, 2 :: (store 4 into stack + 4)
|
||||
MOV32mi %0, 1, _, 0, _, 1 :: (store 4 into stack)
|
||||
CALLpcrel32 @good, csr_32, implicit %esp, implicit-def %esp
|
||||
ADJCALLSTACKUP32 16, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
ADJCALLSTACKDOWN32 20, 0, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
%1 = MOV32rm %stack.2.s, 1, _, 0, _ :: (load 4 from %stack.2.s, align 8)
|
||||
%2 = MOV32rm %stack.2.s, 1, _, 4, _ :: (load 4 from %stack.2.s + 4)
|
||||
%3 = COPY %esp
|
||||
MOV32mr %3, 1, _, 4, _, killed %2 :: (store 4)
|
||||
MOV32mr %3, 1, _, 0, _, killed %1 :: (store 4)
|
||||
%4 = LEA32r %stack.0.p, 1, _, 0, _
|
||||
MOV32mr %3, 1, _, 16, _, killed %4 :: (store 4 into stack + 16)
|
||||
%5 = LEA32r %stack.1.q, 1, _, 0, _
|
||||
MOV32mr %3, 1, _, 12, _, killed %5 :: (store 4 into stack + 12)
|
||||
MOV32mi %3, 1, _, 8, _, 6 :: (store 4 into stack + 8)
|
||||
CALLpcrel32 @struct, csr_32, implicit %esp, implicit-def %esp
|
||||
ADJCALLSTACKUP32 20, 0, implicit-def dead %esp, implicit-def dead %eflags, implicit %esp
|
||||
RET 0
|
||||
|
||||
...
|
||||
Loading…
Reference in New Issue
Block a user